Re: [PATCH v12 1/2] Add 'codepoint_collation' support for LC_COLLATE.

[Carlos O'Donell <carlos@redhat.com>]

On 9/20/21 08:49, Matheus Castanho wrote:
> 
> Carlos O'Donell <carlos@redhat.com> writes:
> 
>> On 9/6/21 1:20 PM, Matheus Castanho wrote:
>>> In file included from C-collate.c:22:
>>> C-collate-seq.c:58:42: error: expected ‘,’ before ‘)’ token
>>>  _Static_assert (sizeof (collseqmb) == 256);
>>>                                           ^
>>
>> Which version of gcc? I assume gcc 8.x? Which distro? I know Florian
>> fixed this, but I'm curious what you're using.
>>
>> So DJ and I just talked about how we would catch this in CI/CD, but
>> we'd have to run fairly old unsupported Fedora to test this, so we'd
>> have to do something different.
> 
> Sorry for the delay. One case where I saw it was using GCC from Debian
> 10:
> 
> $ gcc --version
> gcc (Debian 8.3.0-6) 8.3.0
> [...]

Yea, so that's old enough that it would trigger the failure. Thanks, Florian fixed this 
with commit c9fef4b7d1d0f2dad192c74f06102752247677a9, and we shouldn't regress again
thanks to the requirement for 2 arguments.

-- 
Cheers,
Carlos.