Re: [PATCH v12 1/2] Add 'codepoint_collation' support for LC_COLLATE.

[Carlos O'Donell <carlos@redhat.com>]

On 9/6/21 1:28 PM, Florian Weimer wrote:
> * Matheus Castanho:
> 
>> glibc doesn't build after this patch went in, looks like the assert
>> message is missing:
>>
>> In file included from C-collate.c:22:
>> C-collate-seq.c:58:42: error: expected ‘,’ before ‘)’ token
>>  _Static_assert (sizeof (collseqmb) == 256);
> 
> Sorry, I missed that.  I'm testing a patch.

Thanks for committing a fix for this. I'm using too new compilers
and thinking in too new C :-)

I missed it too, C++ allows the assertion with an expression only
but current C11 does not. That's an annoying wrinkle fixed in C2x
which allows a one-argument version of _Static_assert.

This behaviour changed between gcc 8.5 and 9.1 where in 9.1 under
-std=c11 started accepting the 1-argument-form _Static_assert.

All of our CI/CD is using gcc 11, and I'm using gcc 10, so we would
not have seen this. Seems like we need another CI/CD trybot with
gcc 6.2!

-- 
Cheers,
Carlos.