public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] nscd_stat.c: make the build reproducible
Date: Wed, 09 Mar 2016 07:54:00 -0000	[thread overview]
Message-ID: <20160309075403.GA2444@aurel32.net> (raw)
In-Reply-To: <20160308233738.GP6588@vapier.lan>

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On 2016-03-08 18:37, Mike Frysinger wrote:
> On 08 Mar 2016 18:06, Aurelien Jarno wrote:
> > nscd_stat.c uses the __DATE__ and __TIME__ macros to make sure the
> > client and the server use the same format. This prevents reproducible
> > builds and fails to build with -Werror=date-time. In addition another
> > build of the same file a bit later does not necessary imply a change
> > in the format.
> > 
> > Instead compute a checksum of the file in the Makefile and pass it to
> > the preprocessor with the -D option. Use the md5sum command limited to
> > 20 characters to avoid changing the structure size.
> 
> this doesn't take into consideration the HAVE_SELINUX knob ...

Correct. Back to the design board, I'll try to provide a new solution.
Don't hesitate to tell if you have ideas.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-03-09  7:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 17:06 Aurelien Jarno
2016-03-08 23:37 ` Mike Frysinger
2016-03-09  7:54   ` Aurelien Jarno [this message]
2016-03-09 22:30     ` Mike Frysinger
2016-07-28 19:33       ` Florian Weimer
2016-07-29 13:30         ` Ludovic Courtès
2016-08-01  4:52         ` Mike Frysinger
2016-11-04 17:54           ` Ximin Luo
2016-11-04 18:14             ` Ximin Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160309075403.GA2444@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).