From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, joseph@codesourcery.com
Subject: Re: [PATCH] Use read_int in vfscanf
Date: Wed, 26 Oct 2016 12:56:00 -0000 [thread overview]
Message-ID: <20161026105611.55a948c7@keller> (raw)
In-Reply-To: <482ccd6e-5d17-c87f-2033-030493118f70@redhat.com>
On Thu, 6 Oct 2016 14:21:39 +0200
Florian Weimer <fweimer@redhat.com> wrote:
> On 09/23/2016 03:50 AM, Gabriel F. T. Gomes wrote:
>
> > + argpos = read_int ((const UCHAR_T **) &f);
>
> This is a const char * → const unsigned char * cast in the non-wide case
> (and okay), but in the wide case, it goes from const int * to const
> unsigned int *, which is not valid. This is a pre-existing issue in
> vfprintf.c, so I don't think it should block inclusion of this cleanup.
Thanks. Pushed as 726d48ec.
prev parent reply other threads:[~2016-10-26 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 1:50 Gabriel F. T. Gomes
2016-10-06 12:21 ` Florian Weimer
2016-10-26 12:56 ` Gabriel F. T. Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026105611.55a948c7@keller \
--to=gftg@linux.vnet.ibm.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).