From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix warning caused by unused-result in bug-atexit3-lib.cc
Date: Fri, 28 Oct 2016 13:33:00 -0000 [thread overview]
Message-ID: <20161028113240.2ae7dbef@keller> (raw)
In-Reply-To: <6916e095-d2bd-20ee-57d9-0f1509cfb389@redhat.com>
On Fri, 28 Oct 2016 15:04:13 +0200
Florian Weimer <fweimer@redhat.com> wrote:
> On 10/28/2016 03:00 PM, Gabriel F. T. Gomes wrote:
> > The test case dlfcn/bug-atexit3-lib.cc calls write and doesn't check the
> > result. When building with GCC 6.2 from IBM's branch, this generates a
> > warning in 'make check', which is treated as an error. This patch adds a
> > return variable to get rid of the warning and of the error.
>
> You could use write_message from test-skeleton.c instead. it has a
> proper unused variable guard.
Is it ok to use write_message in c++ code being built as object?
Thanks,
Gabriel
next prev parent reply other threads:[~2016-10-28 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 13:01 Gabriel F. T. Gomes
2016-10-28 13:04 ` Florian Weimer
2016-10-28 13:33 ` Gabriel F. T. Gomes [this message]
2016-10-28 13:35 ` Florian Weimer
2016-10-28 17:58 ` [PATCH v2] " Gabriel F. T. Gomes
2016-10-28 20:38 ` Florian Weimer
2016-10-28 21:47 ` Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028113240.2ae7dbef@keller \
--to=gftg@linux.vnet.ibm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).