From: Sergei Trofimovich <slyich@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org,
Sergei Trofimovich <siarheit@google.com>,
Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH] m68k: restore handling of R_68K_NONE in elf_machine_lazy_rel()
Date: Sat, 29 Oct 2016 16:15:00 -0000 [thread overview]
Message-ID: <20161029171527.423b573e@sf> (raw)
In-Reply-To: <87pomjnp3v.fsf@linux-m68k.org>
On Sat, 29 Oct 2016 17:37:08 +0200
Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Okt 29 2016, slyich@gmail.com wrote:
>
> > commit 96e1bff2513873062233a13c7fd1eea57bb8db24
> > Author: Roland McGrath <roland@gnu.org>
> > Date: Wed Jul 17 18:00:33 1996 +0000
>
> ??? This commit touches csu/initfini.c only.
>
> Andreas.
I was looking at this tree:
Commit https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=96e1bff2513873062233a13c7fd1eea57bb8db24
among other thing shows disappearance of 'case R_68K_NONE':
-static inline void
-elf_machine_lazy_rel (struct link_map *map, const Elf32_Rela *reloc)
-{
- Elf32_Addr *const reloc_addr = (void *) (map->l_addr + reloc->r_offset);
- switch (ELF32_R_TYPE (reloc->r_info))
- {
- case R_68K_NONE:
- break;
- case R_68K_JMP_SLOT:
- *reloc_addr += map->l_addr;
- break;
- default:
- assert (! "unexpected PLT reloc type");
- break;
- }
-}
+static inline void
+elf_machine_lazy_rel (struct link_map *map, const Elf32_Rela *reloc)
+{
+ Elf32_Addr *const reloc_addr = (void *) (map->l_addr + reloc->r_offset);
+ switch (ELF32_R_TYPE (reloc->r_info))
+ {
+ case R_68K_JMP_SLOT:
+ *reloc_addr += map->l_addr;
+ break;
+ default:
+ assert (! "unexpected PLT reloc type");
+ break;
+ }
+}
--
Sergei
next prev parent reply other threads:[~2016-10-29 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 13:48 slyich
2016-10-29 15:37 ` Andreas Schwab
2016-10-29 16:15 ` Sergei Trofimovich [this message]
2016-10-29 17:11 ` Andreas Schwab
2016-10-30 10:13 ` Sergei Trofimovich
2016-10-30 11:05 ` Andreas Schwab
2016-11-08 23:56 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029171527.423b573e@sf \
--to=slyich@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=roland@hack.frob.com \
--cc=schwab@linux-m68k.org \
--cc=siarheit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).