public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Sergei Trofimovich <slyich@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org,
	Sergei Trofimovich <siarheit@google.com>,
	Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH] m68k: restore handling of R_68K_NONE in elf_machine_lazy_rel()
Date: Tue, 08 Nov 2016 23:56:00 -0000	[thread overview]
Message-ID: <20161108235630.6357db5f@sf> (raw)
In-Reply-To: <87shrem71g.fsf@linux-m68k.org>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Sun, 30 Oct 2016 12:04:59 +0100
Andreas Schwab <schwab@linux-m68k.org> wrote:

> On Okt 30 2016, Sergei Trofimovich <slyich@gmail.com> wrote:
> 
> > Is there a reason to allow R_68K_NONE for non-lazy relocations
> > in elf_machine_rela()
> >
> > +    case R_68K_NONE:           /* Alright, Wilbur.  */
> > +      break;
> >
> > but forbid R_68K_NONE for lazy relocations
> > in elf_machine_lazy_rel()  
> 
> Because the latter must never happen.  Please file a binutils bug with a
> self-contained test case.

Finally extracted one. Filed as:
    https://sourceware.org/bugzilla/show_bug.cgi?id=20796

It is triggered by a mix of -Wl,--gc-sections, -u buggy_symbol
and a shared library where 'buggy_symbol' comes from.

And while at it filed minor bug about R_68K_NONE relocations
to be present in final binaries:
    https://sourceware.org/bugzilla/show_bug.cgi?id=20797

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

      reply	other threads:[~2016-11-08 23:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29 13:48 slyich
2016-10-29 15:37 ` Andreas Schwab
2016-10-29 16:15   ` Sergei Trofimovich
2016-10-29 17:11     ` Andreas Schwab
2016-10-30 10:13       ` Sergei Trofimovich
2016-10-30 11:05         ` Andreas Schwab
2016-11-08 23:56           ` Sergei Trofimovich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161108235630.6357db5f@sf \
    --to=slyich@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=roland@hack.frob.com \
    --cc=schwab@linux-m68k.org \
    --cc=siarheit@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).