public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [hurd,commited] hurd: fix conformity test for sys/un.h
@ 2018-04-17 23:58 Samuel Thibault
  2018-04-18 11:15 ` Joseph Myers
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Thibault @ 2018-04-17 23:58 UTC (permalink / raw)
  To: libc-alpha; +Cc: Samuel Thibault

sun_len is used by BSD systems, and conformant.

	* conform/data/sys/un.h-data (struct sockaddr_un): Allow sun_len
	member.
---
 ChangeLog                  | 5 +++++
 conform/data/sys/un.h-data | 1 +
 2 files changed, 6 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 381a2ea2b7..cde575fbb1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-04-18  Samuel Thibault  <samuel.thibault@ens-lyon.org>
+
+	* conform/data/sys/un.h-data (struct sockaddr_un): Allow sun_len
+	member.
+
 2018-04-16  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* sysdeps/arm/armv6t2/memchr.S (memchr): Remove ARM code path.
diff --git a/conform/data/sys/un.h-data b/conform/data/sys/un.h-data
index 1068440042..4e00742b9e 100644
--- a/conform/data/sys/un.h-data
+++ b/conform/data/sys/un.h-data
@@ -1,6 +1,7 @@
 #if !defined ISO && !defined ISO99 && !defined ISO11 && !defined POSIX && !defined XPG4
 type {struct sockaddr_un}
 
+optional-element {struct sockaddr_un} {unsigned char} sun_len
 element {struct sockaddr_un} sa_family_t sun_family
 element {struct sockaddr_un} char sun_path []
 
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [hurd,commited] hurd: fix conformity test for sys/un.h
  2018-04-17 23:58 [hurd,commited] hurd: fix conformity test for sys/un.h Samuel Thibault
@ 2018-04-18 11:15 ` Joseph Myers
  0 siblings, 0 replies; 2+ messages in thread
From: Joseph Myers @ 2018-04-18 11:15 UTC (permalink / raw)
  To: Samuel Thibault; +Cc: libc-alpha

On Wed, 18 Apr 2018, Samuel Thibault wrote:

> sun_len is used by BSD systems, and conformant.
> 
> 	* conform/data/sys/un.h-data (struct sockaddr_un): Allow sun_len
> 	member.

This is not correct.  optional-* is used when the relevant standards have 
a specification for a symbol, but do not require it to be defined.  In 
this case, the standards do not have a specification for sun_len - they 
have a permission to define arbitrary sun_* symbols, for which "allow 
sun_*" is the appropriate representation.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-18 11:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 23:58 [hurd,commited] hurd: fix conformity test for sys/un.h Samuel Thibault
2018-04-18 11:15 ` Joseph Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).