From: Samuel Thibault <samuel.thibault@gnu.org>
To: Zack Weinberg <zackw@panix.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
Florian Weimer <fweimer@redhat.com>,
Thomas Schwinge <thomas@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>,
bug-hurd@gnu.org, David Michael <fedora.dm0@gmail.com>
Subject: Re: Upstreaming the glibc Hurd port
Date: Wed, 18 Apr 2018 18:53:00 -0000 [thread overview]
Message-ID: <20180418185342.qaeyh7rcink7ygye@var.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <CAKCAbMiBMgHxki5XWveRz+47CZ4svLhOxpqgXEFdpQ5rc7uaUw@mail.gmail.com>
Zack Weinberg, le mer. 18 avril 2018 14:40:29 -0400, a ecrit:
> On Wed, Apr 18, 2018 at 10:03 AM, Samuel Thibault
> <samuel.thibault@gnu.org> wrote:
> >>
> >> I have a concern: the types 'struct sched_param' and 'struct
> >> __sched_param' are not compatible, even if their members are identical
> >> (6.2.7p1 explicitly requires the tags to be the same for
> >> compatibility).
> >
> > Ah, probably that's why bits/sched.h used to define both sched_param and
> > __sched_param with the __sched_priority field, and #define
> > sched_priority to __sched_priority. I can do that, it's fine.
>
> This is actually worse than having struct sched_param defined by
> sys/types.h, because sched.h is now defining *macro* names that it's
> not supposed to. It's far more likely that a program will try to
> define a variable named 'sched_priority' than that it will try to
> define its own 'struct sched_param'.
Sure. glibc just has been #defining sched_priority for a very long time
already :)
> Can I ask whether you want to keep exposing the internals of pthread_*
> types to applications? If there's a plan to stop doing that - even a
> "yeah but it's hard and we have so many other things to do first"
> intention - then I would recommend leaving sched_param alone for now
> and just XFAILing the conformance test.
That's it indeed.
Samuel
next prev parent reply other threads:[~2018-04-18 18:53 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:39 Florian Weimer
2018-01-18 12:45 ` Samuel Thibault
2018-01-18 12:58 ` Florian Weimer
2018-01-18 13:47 ` Joseph Myers
2018-01-18 13:52 ` Joseph Myers
2018-01-18 13:59 ` Samuel Thibault
2018-01-18 13:58 ` Samuel Thibault
2018-01-18 14:03 ` Joseph Myers
2018-01-28 18:40 ` Samuel Thibault
2018-01-18 14:22 ` Thomas Schwinge
2018-01-18 14:27 ` Samuel Thibault
2018-01-18 15:14 ` Samuel Thibault
2018-01-18 15:35 ` Joseph Myers
2018-01-18 15:42 ` Samuel Thibault
2018-01-18 16:48 ` Joseph Myers
2018-01-18 16:59 ` Samuel Thibault
2018-01-18 23:16 ` Joseph Myers
2018-01-18 23:59 ` Samuel Thibault
2018-01-19 0:34 ` Joseph Myers
2018-01-19 10:10 ` Thomas Schwinge
2018-01-19 12:35 ` Manolis Ragkousis
2018-01-19 13:08 ` Joseph Myers
2018-01-19 14:11 ` Thomas Schwinge
2018-01-19 15:12 ` Joseph Myers
2018-01-19 18:24 ` Zack Weinberg
2018-01-19 18:30 ` Joseph Myers
2018-01-19 17:23 ` Joseph Myers
2018-01-19 17:32 ` Samuel Thibault
2018-01-19 17:50 ` Joseph Myers
2018-01-19 17:59 ` Samuel Thibault
2018-01-24 1:10 ` Samuel Thibault
2018-01-24 1:26 ` Joseph Myers
2018-01-24 1:27 ` Samuel Thibault
2018-01-25 1:41 ` Samuel Thibault
2018-01-25 15:43 ` Joseph Myers
2018-01-25 16:12 ` Joseph Myers
2018-01-25 16:20 ` Samuel Thibault
2018-03-19 1:51 ` Samuel Thibault
2018-03-19 15:36 ` Zack Weinberg
2018-03-19 15:47 ` Samuel Thibault
2018-03-19 15:54 ` Zack Weinberg
2018-03-19 16:05 ` Samuel Thibault
2018-03-26 23:13 ` Rafal Luzynski
2018-03-27 7:45 ` Samuel Thibault
2018-03-27 9:01 ` Samuel Thibault
2018-03-27 10:40 ` Rafal Luzynski
2018-03-27 10:43 ` Samuel Thibault
2018-03-27 10:53 ` Rafal Luzynski
2018-03-27 14:46 ` Tulio Magno Quites Machado Filho
2018-03-27 14:53 ` Carlos O'Donell
2018-03-27 16:31 ` Samuel Thibault
2018-04-02 0:10 ` Samuel Thibault
2018-04-02 7:51 ` Florian Weimer
2018-04-02 8:24 ` Samuel Thibault
2018-04-02 14:17 ` Joseph Myers
2018-04-02 15:50 ` Samuel Thibault
2018-04-02 16:13 ` Samuel Thibault
2018-04-03 0:13 ` Joseph Myers
2018-04-17 22:50 ` Samuel Thibault
2018-04-17 23:02 ` Joseph Myers
2018-04-17 23:08 ` Samuel Thibault
2018-04-18 11:13 ` Joseph Myers
2018-04-18 13:54 ` Zack Weinberg
2018-04-18 14:03 ` Samuel Thibault
2018-04-18 18:40 ` Zack Weinberg
2018-04-18 18:53 ` Samuel Thibault [this message]
2018-04-03 0:10 ` Joseph Myers
2018-04-18 23:57 ` Samuel Thibault
2018-04-21 8:54 ` Samuel Thibault
2018-04-02 14:22 ` Joseph Myers
2018-04-02 14:47 ` Samuel Thibault
2018-04-02 16:01 ` H.J. Lu
2018-04-02 16:16 ` Samuel Thibault
2018-04-02 17:06 ` H.J. Lu
2018-04-02 17:16 ` Samuel Thibault
2018-04-02 17:22 ` H.J. Lu
2018-04-02 17:35 ` Samuel Thibault
2018-04-02 17:37 ` Samuel Thibault
2018-04-03 15:45 ` Joseph Myers
2018-04-03 16:08 ` Samuel Thibault
2018-04-03 21:48 ` Joseph Myers
2018-04-03 21:58 ` Samuel Thibault
2018-04-03 22:07 ` Zack Weinberg
2018-04-03 22:48 ` Joseph Myers
2018-04-05 11:07 ` Florian Weimer
2018-01-18 14:33 ` Samuel Thibault
2018-01-18 15:24 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418185342.qaeyh7rcink7ygye@var.youpi.perso.aquilenet.fr \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=fedora.dm0@gmail.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=thomas@codesourcery.com \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).