From: Joseph Myers <joseph@codesourcery.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>, <bug-hurd@gnu.org>,
David Michael <fedora.dm0@gmail.com>
Subject: Re: Upstreaming the glibc Hurd port
Date: Wed, 24 Jan 2018 01:26:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1801240120210.29863@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180124011051.5s2vugyq3ybnurwc@var.youpi.perso.aquilenet.fr>
On Wed, 24 Jan 2018, Samuel Thibault wrote:
> Hello,
>
> Joseph Myers, on ven. 19 janv. 2018 17:23:29 +0000, wrote:
> > Could Hurd people review how this handles building for Hurd,
>
> Yes, it looks good.
Thanks, I've committed it to master.
> > and indicate whether the above errors indicate problems with these
> > changes, or simply incompleteness of the build support on the
> > sthibaul/hurd-builds branch at present?
>
> They are not related to the changes. I have pushed fix updates against
> them.
Now I see errors about missing libc-lockP.h, and "implicit declaration of
function '__spin_lock_solid'", and the discarded qualifiers errors you
note below.
> There is just one missing thing: mig prototypes etc. are not perfect,
> and we thus have some nasty warnings about void * vs const void *. We'd
> have to use
>
> if self.os == 'gnu':
> cfg_cmd += ['MIG=%s' % self.tool_name('mig')]
> + cfg_cmd += ['--disable-werror']
>
> for now until we fix that.
A properly upstreamed port should not need --disable-werror. If
workarounds are needed until there's a fixed mig release (or whatever),
they could take the form of explicit casts, or CFLAGS-<file> +=
-Wno-error=discarded-qualifiers - disabling a particular warning being an
error in a particular file is much better than globally disabling all
warnings as errors. (Strictly -Wno-error=discarded-qualifiers shouldn't
be used unconditionally since that warning option is new in GCC 5 and
glibc supports building with GCC 4.9, but in the current state of the Hurd
port I think we can ignore that in Hurd-specific Makefiles.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-01-24 1:26 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:39 Florian Weimer
2018-01-18 12:45 ` Samuel Thibault
2018-01-18 12:58 ` Florian Weimer
2018-01-18 13:47 ` Joseph Myers
2018-01-18 13:52 ` Joseph Myers
2018-01-18 13:59 ` Samuel Thibault
2018-01-18 13:58 ` Samuel Thibault
2018-01-18 14:03 ` Joseph Myers
2018-01-28 18:40 ` Samuel Thibault
2018-01-18 14:22 ` Thomas Schwinge
2018-01-18 14:27 ` Samuel Thibault
2018-01-18 15:14 ` Samuel Thibault
2018-01-18 15:35 ` Joseph Myers
2018-01-18 15:42 ` Samuel Thibault
2018-01-18 16:48 ` Joseph Myers
2018-01-18 16:59 ` Samuel Thibault
2018-01-18 23:16 ` Joseph Myers
2018-01-18 23:59 ` Samuel Thibault
2018-01-19 0:34 ` Joseph Myers
2018-01-19 10:10 ` Thomas Schwinge
2018-01-19 12:35 ` Manolis Ragkousis
2018-01-19 13:08 ` Joseph Myers
2018-01-19 14:11 ` Thomas Schwinge
2018-01-19 15:12 ` Joseph Myers
2018-01-19 18:24 ` Zack Weinberg
2018-01-19 18:30 ` Joseph Myers
2018-01-19 17:23 ` Joseph Myers
2018-01-19 17:32 ` Samuel Thibault
2018-01-19 17:50 ` Joseph Myers
2018-01-19 17:59 ` Samuel Thibault
2018-01-24 1:10 ` Samuel Thibault
2018-01-24 1:26 ` Joseph Myers [this message]
2018-01-24 1:27 ` Samuel Thibault
2018-01-25 1:41 ` Samuel Thibault
2018-01-25 15:43 ` Joseph Myers
2018-01-25 16:12 ` Joseph Myers
2018-01-25 16:20 ` Samuel Thibault
2018-03-19 1:51 ` Samuel Thibault
2018-03-19 15:36 ` Zack Weinberg
2018-03-19 15:47 ` Samuel Thibault
2018-03-19 15:54 ` Zack Weinberg
2018-03-19 16:05 ` Samuel Thibault
2018-03-26 23:13 ` Rafal Luzynski
2018-03-27 7:45 ` Samuel Thibault
2018-03-27 9:01 ` Samuel Thibault
2018-03-27 10:40 ` Rafal Luzynski
2018-03-27 10:43 ` Samuel Thibault
2018-03-27 10:53 ` Rafal Luzynski
2018-03-27 14:46 ` Tulio Magno Quites Machado Filho
2018-03-27 14:53 ` Carlos O'Donell
2018-03-27 16:31 ` Samuel Thibault
2018-04-02 0:10 ` Samuel Thibault
2018-04-02 7:51 ` Florian Weimer
2018-04-02 8:24 ` Samuel Thibault
2018-04-02 14:17 ` Joseph Myers
2018-04-02 15:50 ` Samuel Thibault
2018-04-02 16:13 ` Samuel Thibault
2018-04-03 0:13 ` Joseph Myers
2018-04-17 22:50 ` Samuel Thibault
2018-04-17 23:02 ` Joseph Myers
2018-04-17 23:08 ` Samuel Thibault
2018-04-18 11:13 ` Joseph Myers
2018-04-18 13:54 ` Zack Weinberg
2018-04-18 14:03 ` Samuel Thibault
2018-04-18 18:40 ` Zack Weinberg
2018-04-18 18:53 ` Samuel Thibault
2018-04-03 0:10 ` Joseph Myers
2018-04-18 23:57 ` Samuel Thibault
2018-04-21 8:54 ` Samuel Thibault
2018-04-02 14:22 ` Joseph Myers
2018-04-02 14:47 ` Samuel Thibault
2018-04-02 16:01 ` H.J. Lu
2018-04-02 16:16 ` Samuel Thibault
2018-04-02 17:06 ` H.J. Lu
2018-04-02 17:16 ` Samuel Thibault
2018-04-02 17:22 ` H.J. Lu
2018-04-02 17:35 ` Samuel Thibault
2018-04-02 17:37 ` Samuel Thibault
2018-04-03 15:45 ` Joseph Myers
2018-04-03 16:08 ` Samuel Thibault
2018-04-03 21:48 ` Joseph Myers
2018-04-03 21:58 ` Samuel Thibault
2018-04-03 22:07 ` Zack Weinberg
2018-04-03 22:48 ` Joseph Myers
2018-04-05 11:07 ` Florian Weimer
2018-01-18 14:33 ` Samuel Thibault
2018-01-18 15:24 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801240120210.29863@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=bug-hurd@gnu.org \
--cc=fedora.dm0@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).