* [PATCH v2] tst-tzset: Use default timeout (20 seconds as of now)
@ 2018-07-30 16:13 Alexey Brodkin
0 siblings, 0 replies; only message in thread
From: Alexey Brodkin @ 2018-07-30 16:13 UTC (permalink / raw)
To: libc-alpha; +Cc: linux-snps-arc, Alexey Brodkin, Joseph Myers, Andreas Schwab
The timeout was set to 5 seconds in commit
112f28e88c4e ("tst-tzset: raise timeout to 5 seconds") to increase it
from a default 2 seconds.
That was before the default timeout was changed to 20 seconds in commit
a28605b22946 (" test-skeleton: increase default TIMEOUT to 20 seconds").
If there's no good reason to limit execution time to less than default
we shouldn't specify random values. That said in tst-tzset we'll be
using default 20 seconds from now on.
Cc: Joseph Myers <joseph@codesourcery.com>
Cc: Andreas Schwab <schwab@suse.de>
---
Changes v1 -> v2:
* Rely on default timeout instead of test-specific one
timezone/tst-tzset.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
index 27f986b56dab..fca704c2ad2d 100644
--- a/timezone/tst-tzset.c
+++ b/timezone/tst-tzset.c
@@ -25,7 +25,6 @@
#include <time.h>
#include <unistd.h>
-#define TIMEOUT 5
static int do_test (void);
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"
--
2.17.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-30 16:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 16:13 [PATCH v2] tst-tzset: Use default timeout (20 seconds as of now) Alexey Brodkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).