From: Lukasz Majewski <lukma@denx.de>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] tst: Provide test for getrusage
Date: Mon, 15 Mar 2021 14:56:09 +0100 [thread overview]
Message-ID: <20210315145609.443f55ec@jawa> (raw)
In-Reply-To: <87wnu83cun.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 2313 bytes --]
Hi Andreas,
> On Mär 15 2021, Lukasz Majewski wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/tst-getrusage.c
> > b/sysdeps/unix/sysv/linux/tst-getrusage.c new file mode 100644
> > index 0000000000..068becdadb
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/tst-getrusage.c
> > @@ -0,0 +1,55 @@
> > +/* Test for getrusage
> > + Copyright (C) 2021 Free Software Foundation, Inc.
> > + This file is part of the GNU C Library.
> > +
> > + The GNU C Library is free software; you can redistribute it
> > and/or
> > + modify it under the terms of the GNU Lesser General Public
> > + License as published by the Free Software Foundation; either
> > + version 2.1 of the License, or (at your option) any later
> > version. +
> > + The GNU C Library is distributed in the hope that it will be
> > useful,
> > + but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > GNU
> > + Lesser General Public License for more details.
> > +
> > + You should have received a copy of the GNU Lesser General Public
> > + License along with the GNU C Library; if not, see
> > + <https://www.gnu.org/licenses/>. */
> > +
> > +#include <time.h>
> > +#include <sys/resource.h>
> > +#include <support/check.h>
> > +#include <support/timespec.h>
> > +
> > +#define TST_GETRUSAGE_TIMEOUT 1
> > +
> > +static int
> > +do_test (void)
> > +{
> > + struct timespec tv_then, tv_now, gru_u, gru_s, s, r;
> > + struct rusage ru;
> > + int ret;
> > +
> > + tv_then = xclock_now (CLOCK_REALTIME);
> > + /* Busy wait for 1 second. */
> > + do
> > + {
> > + tv_now = xclock_now (CLOCK_REALTIME);
> > + r = timespec_sub (tv_now, tv_then);
> > + } while ( r.tv_sec != TST_GETRUSAGE_TIMEOUT );
>
> What happens if the process stalls for a second?
I think that the glibc's test infrastructure will kill it - the default
timeout is 2 seconds.
As a result the test will fail.
>
> Andreas.
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-15 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 10:42 Lukasz Majewski
2021-03-15 10:55 ` Andreas Schwab
2021-03-15 13:56 ` Lukasz Majewski [this message]
2021-03-17 16:04 ` Lukasz Majewski
2021-03-17 16:24 ` Andreas Schwab
2021-03-22 11:29 ` Lukasz Majewski
2021-03-22 19:47 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315145609.443f55ec@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).