From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH 03/15] linux: Add lutimes test
Date: Tue, 23 Mar 2021 10:44:46 -0300 [thread overview]
Message-ID: <20210323134458.2563022-4-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20210323134458.2563022-1-adhemerval.zanella@linaro.org>
It uses stat to compare against the values set by lutimes.
Checked on x86_64-linux-gnu and i686-linux-gnu.
---
io/Makefile | 1 +
io/tst-futimens.c | 2 +-
io/tst-futimes.c | 2 +-
io/tst-lutimes.c | 53 +++++++++++++++++++++++++++++++++++++
io/tst-utime.c | 2 +-
io/tst-utimensat-skeleton.c | 7 ++++-
io/tst-utimes.c | 2 +-
7 files changed, 64 insertions(+), 5 deletions(-)
create mode 100644 io/tst-lutimes.c
diff --git a/io/Makefile b/io/Makefile
index 0002e108a6..bec0e5871e 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -72,6 +72,7 @@ tests := test-utime test-stat test-stat2 test-lfs tst-getcwd \
tst-utime \
tst-utimes \
tst-futimes \
+ tst-lutimes \
tst-futimens \
# Likewise for statx, but we do not need static linking here.
diff --git a/io/tst-futimens.c b/io/tst-futimens.c
index ac7a980017..b3e3f3137f 100644
--- a/io/tst-futimens.c
+++ b/io/tst-futimens.c
@@ -38,7 +38,7 @@ test_futimens_helper (const char *file, int fd, const struct timespec *ts)
return 0;
}
-#define TEST_CALL(fname, fd, v1, v2) \
+#define TEST_CALL(fname, fd, lname, v1, v2) \
test_futimens_helper (fname, fd, (struct timespec[]) { { v1, 0 }, \
{ v2, 0 } })
diff --git a/io/tst-futimes.c b/io/tst-futimes.c
index ea7ac7d5f8..bdef38d7cb 100644
--- a/io/tst-futimes.c
+++ b/io/tst-futimes.c
@@ -39,7 +39,7 @@ test_futimens_helper (const char *file, int fd, const struct timeval *tv)
return 0;
}
-#define TEST_CALL(fname, fd, v1, v2) \
+#define TEST_CALL(fname, fd, lname, v1, v2) \
test_futimens_helper (fname, fd, (struct timeval[]) { { v1, 0 }, \
{ v2, 0 } })
diff --git a/io/tst-lutimes.c b/io/tst-lutimes.c
new file mode 100644
index 0000000000..b2da3c5796
--- /dev/null
+++ b/io/tst-lutimes.c
@@ -0,0 +1,53 @@
+/* Test for lutimes.
+ Copyright (C) 2021 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+
+static int
+test_lutimes_helper (const char *testfile, int fd, const char *testlink,
+ const struct timeval *tv)
+{
+ struct stat64 stfile_orig;
+ xlstat (testfile, &stfile_orig);
+
+ TEST_VERIFY_EXIT (lutimes (testlink, tv) == 0);
+
+ struct stat64 stlink;
+ xlstat (testlink, &stlink);
+
+ TEST_COMPARE (stlink.st_atime, tv[0].tv_sec);
+ TEST_COMPARE (stlink.st_mtime, tv[1].tv_sec);
+
+ /* Check if the timestamp from original file is not changed. */
+ struct stat64 stfile;
+ xlstat (testfile, &stfile);
+
+ TEST_COMPARE (stfile_orig.st_atime, stfile.st_atime);
+ TEST_COMPARE (stfile_orig.st_mtime, stfile.st_mtime);
+
+ return 0;
+}
+
+#define TEST_CALL(fname, fd, lname, v1, v2) \
+ test_lutimes_helper (fname, fd, lname, (struct timeval[]) { { v1, 0 }, \
+ { v2, 0 } })
+
+#include "tst-utimensat-skeleton.c"
diff --git a/io/tst-utime.c b/io/tst-utime.c
index c1c7e75a29..6269ef7929 100644
--- a/io/tst-utime.c
+++ b/io/tst-utime.c
@@ -39,7 +39,7 @@ test_utime_helper (const char *file, int fd, const struct utimbuf *ut)
return 0;
}
-#define TEST_CALL(fname, fd, v1, v2) \
+#define TEST_CALL(fname, fd, lname, v1, v2) \
test_utime_helper (fname, fd, &(struct utimbuf) { (v1), (v2) })
#include "tst-utimensat-skeleton.c"
diff --git a/io/tst-utimensat-skeleton.c b/io/tst-utimensat-skeleton.c
index 3589146db5..ad9f6763c5 100644
--- a/io/tst-utimensat-skeleton.c
+++ b/io/tst-utimensat-skeleton.c
@@ -24,6 +24,7 @@
static int temp_fd = -1;
static char *testfile;
+static char *testlink;
const static struct {
int64_t v1;
@@ -49,6 +50,10 @@ do_prepare (int argc, char *argv[])
{
temp_fd = create_temp_file ("utime", &testfile);
TEST_VERIFY_EXIT (temp_fd > 0);
+
+ testlink = xasprintf ("%s-symlink", testfile);
+ xsymlink (testfile, testlink);
+ add_temp_file (testlink);
}
static int
@@ -82,7 +87,7 @@ do_test (void)
continue;
}
- TEST_CALL (testfile, temp_fd, tests[i].v1, tests[i].v2);
+ TEST_CALL (testfile, temp_fd, testlink, tests[i].v1, tests[i].v2);
}
return 0;
diff --git a/io/tst-utimes.c b/io/tst-utimes.c
index ba710508b7..991ab0c7d3 100644
--- a/io/tst-utimes.c
+++ b/io/tst-utimes.c
@@ -40,7 +40,7 @@ test_utimes_helper (const char *file, int fd, const struct timeval *tv)
return 0;
}
-#define TEST_CALL(fname, fd, v1, v2) \
+#define TEST_CALL(fname, fd, lname, v1, v2) \
test_utimes_helper (fname, fd, (struct timeval[]) { { v1, 0 }, \
{ v2, 0 } })
--
2.27.0
next prev parent reply other threads:[~2021-03-23 13:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:44 [PATCH 00/15] Add some tests and infra changes Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 01/15] io: Move file timestamps tests out of Linux Adhemerval Zanella
2021-04-15 5:04 ` Siddhesh Poyarekar
2021-04-15 5:15 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 02/15] linux: Add futimes test Adhemerval Zanella
2021-04-15 5:07 ` Siddhesh Poyarekar
2021-03-23 13:44 ` Adhemerval Zanella [this message]
2021-04-15 5:25 ` [PATCH 03/15] linux: Add lutimes test Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 04/15] io: Add basic tests for utimensat Adhemerval Zanella
2021-04-15 5:33 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 05/15] io: Use temporary directory and file for ftwtest-sh Adhemerval Zanella
2021-03-23 14:24 ` Andreas Schwab
2021-03-23 16:03 ` Adhemerval Zanella
2021-04-15 5:46 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 06/15] time: Add getitimer and setitimer basic tests Adhemerval Zanella
2021-04-15 5:59 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 07/15] time: Add gmtime/gmtime_r tests Adhemerval Zanella
2021-04-15 6:01 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 08/15] time: Add timegm/timelocal basic tests Adhemerval Zanella
2021-03-23 14:28 ` Andreas Schwab
2021-03-23 15:53 ` Adhemerval Zanella
2021-04-15 6:05 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 09/15] time: Add basic timespec_get tests Adhemerval Zanella
2021-04-15 6:08 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 10/15] time: Add 64 bit tests for getdate / getdate_r Adhemerval Zanella
2021-04-15 6:16 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 11/15] posix: Add wait3 tests Adhemerval Zanella
2021-04-15 6:26 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 12/15] linux: mips: Split libpthread.abilist in n32 and n64 Adhemerval Zanella
2021-04-15 7:01 ` Siddhesh Poyarekar
2021-04-15 12:00 ` Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 13/15] linux: mips: Split librt.abilist " Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 14/15] linux: mips: Split libanl.abilist " Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 15/15] linux: s390: Add libanl.abilist in s390 and s390x Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323134458.2563022-4-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).