From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@linux-m68k.org>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 08/15] time: Add timegm/timelocal basic tests
Date: Tue, 23 Mar 2021 12:53:12 -0300 [thread overview]
Message-ID: <b07bee86-a878-d094-9a70-bbce989dbc28@linaro.org> (raw)
In-Reply-To: <87zgyulzbc.fsf@igel.home>
On 23/03/2021 11:28, Andreas Schwab wrote:
> On Mär 23 2021, Adhemerval Zanella via Libc-alpha wrote:
>
>> + /* timelocal is a alias to timegm with the only difference it takes local
>> + timezone into account, while timegm takes the input value to be UTC. */
>
> That doesn't make sense. How can they be aliases if they differ?
Indeed, I got confused there. A better comment would be:
| /* timelocal is an alias to mktime and behaves like timegm with the
| difference that it takes timezone into account. */
next prev parent reply other threads:[~2021-03-23 15:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:44 [PATCH 00/15] Add some tests and infra changes Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 01/15] io: Move file timestamps tests out of Linux Adhemerval Zanella
2021-04-15 5:04 ` Siddhesh Poyarekar
2021-04-15 5:15 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 02/15] linux: Add futimes test Adhemerval Zanella
2021-04-15 5:07 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 03/15] linux: Add lutimes test Adhemerval Zanella
2021-04-15 5:25 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 04/15] io: Add basic tests for utimensat Adhemerval Zanella
2021-04-15 5:33 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 05/15] io: Use temporary directory and file for ftwtest-sh Adhemerval Zanella
2021-03-23 14:24 ` Andreas Schwab
2021-03-23 16:03 ` Adhemerval Zanella
2021-04-15 5:46 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 06/15] time: Add getitimer and setitimer basic tests Adhemerval Zanella
2021-04-15 5:59 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 07/15] time: Add gmtime/gmtime_r tests Adhemerval Zanella
2021-04-15 6:01 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 08/15] time: Add timegm/timelocal basic tests Adhemerval Zanella
2021-03-23 14:28 ` Andreas Schwab
2021-03-23 15:53 ` Adhemerval Zanella [this message]
2021-04-15 6:05 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 09/15] time: Add basic timespec_get tests Adhemerval Zanella
2021-04-15 6:08 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 10/15] time: Add 64 bit tests for getdate / getdate_r Adhemerval Zanella
2021-04-15 6:16 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 11/15] posix: Add wait3 tests Adhemerval Zanella
2021-04-15 6:26 ` Siddhesh Poyarekar
2021-03-23 13:44 ` [PATCH 12/15] linux: mips: Split libpthread.abilist in n32 and n64 Adhemerval Zanella
2021-04-15 7:01 ` Siddhesh Poyarekar
2021-04-15 12:00 ` Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 13/15] linux: mips: Split librt.abilist " Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 14/15] linux: mips: Split libanl.abilist " Adhemerval Zanella
2021-03-23 13:44 ` [PATCH 15/15] linux: s390: Add libanl.abilist in s390 and s390x Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b07bee86-a878-d094-9a70-bbce989dbc28@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).