From: "Fāng-ruì Sòng" <maskray@google.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/3] arm: Use internal symbol for _dl_argv on _dl_start_user
Date: Mon, 1 Nov 2021 09:38:32 -0700 [thread overview]
Message-ID: <20211101163832.fwhpd5hvo6w2ybtj@google.com> (raw)
In-Reply-To: <20211101125003.500945-2-adhemerval.zanella@linaro.org>
On 2021-11-01, Adhemerval Zanella wrote:
>The lld does not support R_ARM_GOTOFF32 to preemptible symbol (_dl_argv
>has global visibility). Use the internal alias instead (one option
s/global visibility/default visibility/
>would to use HIDDEN_JUMPTARGET, bu the macro is not defined for
>!__ASSEMBLER__ and I made this patch arm-specific to avoid require to
>check extensivelly on other architecture it this might break something).
>
>Checked on arm-linux-gnueabihf.
>---
> sysdeps/arm/dl-machine.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h
>index c758bba169..4ecdde4355 100644
>--- a/sysdeps/arm/dl-machine.h
>+++ b/sysdeps/arm/dl-machine.h
>@@ -202,7 +202,7 @@ _dl_start_user:\n\
> .L_FINI_PROC:\n\
> .word _dl_fini(GOTOFF)\n\
> .L_ARGV:\n\
>- .word _dl_argv(GOTOFF)\n\
>+ .word __GI__dl_argv(GOTOFF)\n\
> .L_LOADED:\n\
> .word _rtld_local(GOTOFF)\n\
> .previous\n\
>--
>2.32.0
>
Reviewed-by: Fangrui Song <maskray@google.com>
next prev parent reply other threads:[~2021-11-01 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 12:50 [PATCH 0/3] Fix lld build for armhf Adhemerval Zanella
2021-11-01 12:50 ` [PATCH 1/3] arm: Use internal symbol for _dl_argv on _dl_start_user Adhemerval Zanella
2021-11-01 16:38 ` Fāng-ruì Sòng [this message]
2021-11-01 12:50 ` [PATCH 2/3] arm: Use have-mtls-dialect-gnu2 to check for ARM TLS descriptors support Adhemerval Zanella
2021-11-01 16:42 ` Fāng-ruì Sòng
2021-11-01 12:50 ` [PATCH 3/3] elf: Assume disjointed .rela.dyn and .rela.plt for loader Adhemerval Zanella
2021-11-01 16:44 ` Adhemerval Zanella
2021-11-01 17:16 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101163832.fwhpd5hvo6w2ybtj@google.com \
--to=maskray@google.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).