From: Fangrui Song <maskray@google.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x86-64: Replace movzx with movzbl
Date: Tue, 2 Nov 2021 18:15:31 -0700 [thread overview]
Message-ID: <20211103011531.yiuufsybf5e56rnt@google.com> (raw)
In-Reply-To: <CAMe9rOpJ_82UO3Bvkif_5KJFmY+9_J8Tj1hBO---f2gvEALq6g@mail.gmail.com>
On 2021-11-02, H.J. Lu wrote:
>On Tue, Nov 2, 2021 at 1:45 PM Fangrui Song <maskray@google.com> wrote:
>>
>> Clang cannot assemble movzx in the AT&T dialect mode.
>>
>> ../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction
>> movzx (%rsi), %ecx
>> ^~~~
>>
>> Change movzx to movzbl, which follows the AT&T dialect and is used
>> elsewhere in the file.
>> ---
>> sysdeps/x86_64/strcmp.S | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S
>> index c7cbe4042a..bfe83abede 100644
>> --- a/sysdeps/x86_64/strcmp.S
>> +++ b/sysdeps/x86_64/strcmp.S
>> @@ -2229,8 +2229,8 @@ LABEL(strcmp_exitz):
>>
>> .p2align 4
>> LABEL(Byte0):
>> - movzx (%rsi), %ecx
>> - movzx (%rdi), %eax
>> + movzbl (%rsi), %ecx
>> + movzbl (%rdi), %eax
>>
>> #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
>> leaq _nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
>> --
>> 2.33.1.1089.g2158813163f-goog
>>
>
>LGTM.
>
>Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
>Thanks.
Thanks for the quick review!
Just noticed that sysdeps/x86_64/multiarch/strcmp-sse42.S has a similar
pattern which needs fixing as well. I'll fix that, too.
next prev parent reply other threads:[~2021-11-03 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 20:44 Fangrui Song
2021-11-02 21:14 ` H.J. Lu
2021-11-03 1:15 ` Fangrui Song [this message]
2022-04-23 1:36 ` Sunil Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103011531.yiuufsybf5e56rnt@google.com \
--to=maskray@google.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).