* [PATCH] intl: Emit no lines in bison generated files
@ 2021-12-02 7:13 Khem Raj
2021-12-07 17:37 ` Adhemerval Zanella
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2021-12-02 7:13 UTC (permalink / raw)
To: libc-alpha; +Cc: Khem Raj, Juro Bystricky
Improve reproducibility:
Do not put any #line preprocessor commands in bison generated files.
These lines contain absolute paths containing file locations on
the host build machine.
Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
intl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/intl/Makefile b/intl/Makefile
index 93478d87e8..b27a7935eb 100644
--- a/intl/Makefile
+++ b/intl/Makefile
@@ -155,7 +155,7 @@ $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out
CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \
-D'LOCALE_ALIAS_PATH="$(localedir)"'
-BISONFLAGS = --yacc --name-prefix=__gettext --output
+BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output
$(inst_localedir)/locale.alias: locale.alias $(+force)
$(do-install)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] intl: Emit no lines in bison generated files
2021-12-02 7:13 [PATCH] intl: Emit no lines in bison generated files Khem Raj
@ 2021-12-07 17:37 ` Adhemerval Zanella
2021-12-09 20:05 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2021-12-07 17:37 UTC (permalink / raw)
To: Khem Raj, libc-alpha; +Cc: Juro Bystricky
On 02/12/2021 04:13, Khem Raj via Libc-alpha wrote:
> Improve reproducibility:
Is there any other reproducibility issue?
> Do not put any #line preprocessor commands in bison generated files.
> These lines contain absolute paths containing file locations on
> the host build machine.
>
> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
I think it should be ok to trade some debug information with
reproducibility.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> intl/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/intl/Makefile b/intl/Makefile
> index 93478d87e8..b27a7935eb 100644
> --- a/intl/Makefile
> +++ b/intl/Makefile
> @@ -155,7 +155,7 @@ $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out
>
> CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \
> -D'LOCALE_ALIAS_PATH="$(localedir)"'
> -BISONFLAGS = --yacc --name-prefix=__gettext --output
> +BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output
>
> $(inst_localedir)/locale.alias: locale.alias $(+force)
> $(do-install)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] intl: Emit no lines in bison generated files
2021-12-07 17:37 ` Adhemerval Zanella
@ 2021-12-09 20:05 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2021-12-09 20:05 UTC (permalink / raw)
To: Adhemerval Zanella; +Cc: GNU C Library, Juro Bystricky
On Tue, Dec 7, 2021 at 9:37 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 02/12/2021 04:13, Khem Raj via Libc-alpha wrote:
> > Improve reproducibility:
>
> Is there any other reproducibility issue?
I dont think we have more in Yocto that needed patching besides this.
>
> > Do not put any #line preprocessor commands in bison generated files.
> > These lines contain absolute paths containing file locations on
> > the host build machine.
> >
> > Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> I think it should be ok to trade some debug information with
> reproducibility.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> > ---
> > intl/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/intl/Makefile b/intl/Makefile
> > index 93478d87e8..b27a7935eb 100644
> > --- a/intl/Makefile
> > +++ b/intl/Makefile
> > @@ -155,7 +155,7 @@ $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out
> >
> > CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \
> > -D'LOCALE_ALIAS_PATH="$(localedir)"'
> > -BISONFLAGS = --yacc --name-prefix=__gettext --output
> > +BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output
> >
> > $(inst_localedir)/locale.alias: locale.alias $(+force)
> > $(do-install)
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-09 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 7:13 [PATCH] intl: Emit no lines in bison generated files Khem Raj
2021-12-07 17:37 ` Adhemerval Zanella
2021-12-09 20:05 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).