From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 8/8] nptl: rseq failure after registration on main thread is fatal
Date: Wed, 8 Dec 2021 17:36:38 +0000 [thread overview]
Message-ID: <20211208173638.GL3294453@arm.com> (raw)
In-Reply-To: <354a2d43774aeca68104a6230caa4be7141ed43b.1638880889.git.fweimer@redhat.com>
The 12/07/2021 14:04, Florian Weimer via Libc-alpha wrote:
> This simplifies the application programming model.
>
> Browser sandboxes have already been fixed:
>
> Sandbox is incompatible with rseq registration
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1651701>
>
> Allow rseq in the Linux sandboxes. r=gcp
> <https://hg.mozilla.org/mozilla-central/rev/042425712eb1>
>
> Sandbox needs to support rseq system call
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1104160>
>
> Linux sandbox: Allow rseq(2)
> <https://chromium.googlesource.com/chromium/src.git/+/230675d9ac8f1>
> ---
> v2: New patch. Tested with Firefox 94.0 on Fedora 35.
looks good.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> nptl/pthread_create.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c
> index 4608fd9068..c097fc54e6 100644
> --- a/nptl/pthread_create.c
> +++ b/nptl/pthread_create.c
> @@ -370,7 +370,8 @@ start_thread (void *arg)
> /* Register rseq TLS to the kernel. */
> {
> bool do_rseq = THREAD_GETMEM (pd, flags) & ATTR_FLAG_DO_RSEQ;
> - rseq_register_current_thread (pd, do_rseq);
> + if (!rseq_register_current_thread (pd, do_rseq) && do_rseq)
> + __libc_fatal ("Fatal glibc error: rseq registration failed\n");
> }
>
> #ifndef __ASSUME_SET_ROBUST_LIST
> --
> 2.33.1
>
next prev parent reply other threads:[~2021-12-08 17:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 12:59 [PATCH v2 0/8] Extensible rseq integration Florian Weimer
2021-12-07 13:00 ` [PATCH 1/8] nptl: Add <thread_pointer.h> for defining __thread_pointer Florian Weimer
2021-12-08 11:05 ` Szabolcs Nagy
2021-12-08 17:55 ` Florian Weimer
2021-12-09 11:52 ` Szabolcs Nagy
2021-12-07 13:00 ` [PATCH v2 2/8] nptl: Introduce <tcb-access.h> for THREAD_* accessors Florian Weimer
2021-12-08 11:09 ` Szabolcs Nagy
2021-12-07 13:00 ` [PATCH v2 3/8] nptl: Introduce THREAD_GETMEM_VOLATILE Florian Weimer
2021-12-08 11:23 ` Szabolcs Nagy
2021-12-07 13:01 ` [PATCH 4/8] nptl: Add rseq registration Florian Weimer
2021-12-08 16:51 ` Szabolcs Nagy
2021-12-08 18:03 ` Siddhesh Poyarekar
2021-12-08 18:08 ` Florian Weimer
2021-12-08 23:27 ` Siddhesh Poyarekar
2021-12-09 7:42 ` Florian Weimer
2021-12-09 8:01 ` Siddhesh Poyarekar
2021-12-09 1:51 ` Noah Goldstein
2021-12-07 13:02 ` [PATCH v2 5/8] Linux: Use rseq to accelerate sched_getcpu Florian Weimer
2021-12-08 16:53 ` Szabolcs Nagy
2021-12-07 13:02 ` [PATCH v2 6/8] nptl: Add glibc.pthread.rseq tunable to control rseq registration Florian Weimer
2021-12-08 17:22 ` Szabolcs Nagy
2021-12-08 18:03 ` Siddhesh Poyarekar
2021-12-09 8:03 ` Siddhesh Poyarekar
2021-12-07 13:03 ` [PATCH 7/8] nptl: Add public rseq symbols and <sys/rseq.h> Florian Weimer
2021-12-08 17:34 ` Szabolcs Nagy
2021-12-09 12:26 ` Szabolcs Nagy
2021-12-09 12:34 ` Florian Weimer
2021-12-09 12:36 ` Szabolcs Nagy
2021-12-07 13:04 ` [PATCH v2 8/8] nptl: rseq failure after registration on main thread is fatal Florian Weimer
2021-12-08 17:36 ` Szabolcs Nagy [this message]
2022-02-01 15:21 ` [PATCH v2 0/8] Extensible rseq integration Rich Felker
2022-02-01 16:36 ` Florian Weimer
2022-02-03 0:37 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208173638.GL3294453@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).