From: Rongwei Wang <rongwei.wang@linux.alibaba.com>
To: libc-alpha@sourceware.org, hjl.tools@gmail.com, fweimer@redhat.com
Cc: xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com
Subject: [PATCH v5 0/2] fix p_align on PT_LOAD segment in DSO isn't honored
Date: Fri, 10 Dec 2021 20:39:09 +0800 [thread overview]
Message-ID: <20211210123911.86568-1-rongwei.wang@linux.alibaba.com> (raw)
In-Reply-To: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com>
Hi
This patch mainly to fix a reported bug:
"p_align on PT_LOAD segment in DSO isn't honored"
https://sourceware.org/bugzilla/show_bug.cgi?id=28676
A testcase had been builded by H.J.Lu:
https://sourceware.org/bugzilla/attachment.cgi?id=13838
And in Patch 1/1, I also show a simple testcase which
modified from H.J.Lu.
And a similar bug in ELF binary was also reported:
https://bugzilla.kernel.org/show_bug.cgi?id=215275
A related fix patch could been found:
https://lore.kernel.org/linux-mm/20211009092658.59665-4-rongwei.wang@linux.alibaba.com/
Originally, we send this patch for introducing .text
hugepages, was not aware of it's bug. And now, I am
not sure whether kernel maintainer will regards it as
a bug. But it deserved try again.
Thanks.
Changelog:
v4 -> v5
- Patch "Add a testcase to check alignment of PT_LOAD segment"
add new testcase for PT_LOAD segment
- Patch "elf: Properly align PT_LOAD segments"
fix map_start to use map_start_aligned when second mmap failed
v3 -> v4
- Patch "elf: Properly align PT_LOAD segments"
Call unmap when the second mmap fails.
v2 -> v3
- Patch "elf: Properly align PT_LOAD segments"
move mapalign into 'struct loadcmd'
fix some coding style
RFC/v1 -> v2
- Patch "elf: align the mapping address of LOAD segments with p_align"
fix coding format and add testcase in commit.
RFC link:
https://patchwork.sourceware.org/project/glibc/patch/20211204045848.71105-2-rongwei.wang@linux.alibaba.com/
H.J. Lu (1):
Add a testcase to check alignment of PT_LOAD segment
Rongwei Wang (1):
elf: Properly align PT_LOAD segments
elf/Makefile | 14 +++++++++++--
elf/dl-load.c | 1 +
elf/dl-load.h | 2 +-
elf/dl-map-segments.h | 49 +++++++++++++++++++++++++++++++++++++++----
elf/tst-align3.c | 37 ++++++++++++++++++++++++++++++++
elf/tst-alignmod3.c | 31 +++++++++++++++++++++++++++
6 files changed, 127 insertions(+), 7 deletions(-)
create mode 100644 elf/tst-align3.c
create mode 100644 elf/tst-alignmod3.c
--
2.27.0
next prev parent reply other threads:[~2021-12-10 12:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 4:58 [PATCH RFC 0/1] make ld.so map .text LOAD ssegments and aligned by p_align Rongwei Wang
2021-12-04 4:58 ` [PATCH RFC 1/1] elf: align the mapping address of LOAD segments with p_align Rongwei Wang
2021-12-04 18:10 ` Florian Weimer
2021-12-06 2:47 ` Rongwei Wang
2021-12-06 14:48 ` H.J. Lu
2021-12-08 2:14 ` Rongwei Wang
2021-12-08 2:33 ` H.J. Lu
2021-12-08 3:04 ` Rongwei Wang
2021-12-08 23:52 ` H.J. Lu
2021-12-09 1:43 ` Rongwei Wang
2021-12-10 12:39 ` Rongwei Wang [this message]
2021-12-10 12:39 ` [PATCH v5 1/2] elf: Properly align PT_LOAD segments Rongwei Wang
2021-12-10 15:43 ` H.J. Lu
2021-12-10 15:45 ` Florian Weimer
2021-12-10 18:54 ` H.J. Lu
2021-12-10 18:57 ` H.J. Lu
2021-12-10 12:39 ` [PATCH v5 2/2] Add a testcase to check alignment of PT_LOAD segment Rongwei Wang
2021-12-10 13:48 ` Adhemerval Zanella
2021-12-10 15:41 ` H.J. Lu
2021-12-10 18:56 ` H.J. Lu
2021-12-10 20:05 ` Adhemerval Zanella
2021-12-10 20:24 ` H.J. Lu
2021-12-10 21:34 ` Adhemerval Zanella
2021-12-10 13:13 ` [PATCH v5 0/2] fix p_align on PT_LOAD segment in DSO isn't honored H.J. Lu
2021-12-10 13:58 ` Rongwei Wang
2021-12-13 2:51 ` [PATCH v6 " Rongwei Wang
2021-12-13 2:51 ` [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] Rongwei Wang
2021-12-13 11:05 ` Szabolcs Nagy
2021-12-13 11:17 ` Florian Weimer
2021-12-13 11:35 ` Szabolcs Nagy
2021-12-13 11:59 ` Florian Weimer
2021-12-13 13:20 ` H.J. Lu
2021-12-13 13:26 ` Florian Weimer
2021-12-13 13:34 ` H.J. Lu
2021-12-13 11:46 ` Andreas Schwab
2021-12-13 11:52 ` Szabolcs Nagy
2021-12-13 14:51 ` Rongwei Wang
2021-12-13 17:37 ` Szabolcs Nagy
2021-12-13 17:50 ` Florian Weimer
2021-12-13 2:51 ` [PATCH v6 2/2] Add a testcase to check alignment of PT_LOAD segment Rongwei Wang
2021-12-14 2:03 ` [PATCH v6 0/2] fix p_align on PT_LOAD segment in DSO isn't honored Fangrui Song
2021-12-14 3:56 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210123911.86568-1-rongwei.wang@linux.alibaba.com \
--to=rongwei.wang@linux.alibaba.com \
--cc=fweimer@redhat.com \
--cc=gavin.dg@linux.alibaba.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).