From: Andreas Schwab <schwab@linux-m68k.org>
To: Rongwei Wang via Libc-alpha <libc-alpha@sourceware.org>
Cc: hjl.tools@gmail.com, fweimer@redhat.com,
adhemerval.zanella@linaro.org,
Rongwei Wang <rongwei.wang@linux.alibaba.com>,
xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com
Subject: Re: [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676]
Date: Mon, 13 Dec 2021 12:46:13 +0100 [thread overview]
Message-ID: <87h7bczq0q.fsf@igel.home> (raw)
In-Reply-To: <20211213025103.48472-2-rongwei.wang@linux.alibaba.com> (Rongwei Wang via Libc-alpha's message of "Mon, 13 Dec 2021 10:51:02 +0800")
On Dez 13 2021, Rongwei Wang via Libc-alpha wrote:
> + else
> + {
> + /* Unmap the unused regions. */
> + ElfW(Addr) delta = map_start_aligned - map_start;
> + if (delta)
> + __munmap ((void *) map_start, delta);
> + ElfW(Addr) map_end = map_start_aligned + maplength;
> + delta = map_start + maplen - map_end;
> + if (delta)
> + __munmap ((void *) map_end, delta);
I don't think map_end is guaranteed to be page-aligned.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-12-13 11:46 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 4:58 [PATCH RFC 0/1] make ld.so map .text LOAD ssegments and aligned by p_align Rongwei Wang
2021-12-04 4:58 ` [PATCH RFC 1/1] elf: align the mapping address of LOAD segments with p_align Rongwei Wang
2021-12-04 18:10 ` Florian Weimer
2021-12-06 2:47 ` Rongwei Wang
2021-12-06 14:48 ` H.J. Lu
2021-12-08 2:14 ` Rongwei Wang
2021-12-08 2:33 ` H.J. Lu
2021-12-08 3:04 ` Rongwei Wang
2021-12-08 23:52 ` H.J. Lu
2021-12-09 1:43 ` Rongwei Wang
2021-12-10 12:39 ` [PATCH v5 0/2] fix p_align on PT_LOAD segment in DSO isn't honored Rongwei Wang
2021-12-10 12:39 ` [PATCH v5 1/2] elf: Properly align PT_LOAD segments Rongwei Wang
2021-12-10 15:43 ` H.J. Lu
2021-12-10 15:45 ` Florian Weimer
2021-12-10 18:54 ` H.J. Lu
2021-12-10 18:57 ` H.J. Lu
2021-12-10 12:39 ` [PATCH v5 2/2] Add a testcase to check alignment of PT_LOAD segment Rongwei Wang
2021-12-10 13:48 ` Adhemerval Zanella
2021-12-10 15:41 ` H.J. Lu
2021-12-10 18:56 ` H.J. Lu
2021-12-10 20:05 ` Adhemerval Zanella
2021-12-10 20:24 ` H.J. Lu
2021-12-10 21:34 ` Adhemerval Zanella
2021-12-10 13:13 ` [PATCH v5 0/2] fix p_align on PT_LOAD segment in DSO isn't honored H.J. Lu
2021-12-10 13:58 ` Rongwei Wang
2021-12-13 2:51 ` [PATCH v6 " Rongwei Wang
2021-12-13 2:51 ` [PATCH v6 1/2] elf: Properly align PT_LOAD segments [BZ #28676] Rongwei Wang
2021-12-13 11:05 ` Szabolcs Nagy
2021-12-13 11:17 ` Florian Weimer
2021-12-13 11:35 ` Szabolcs Nagy
2021-12-13 11:59 ` Florian Weimer
2021-12-13 13:20 ` H.J. Lu
2021-12-13 13:26 ` Florian Weimer
2021-12-13 13:34 ` H.J. Lu
2021-12-13 11:46 ` Andreas Schwab [this message]
2021-12-13 11:52 ` Szabolcs Nagy
2021-12-13 14:51 ` Rongwei Wang
2021-12-13 17:37 ` Szabolcs Nagy
2021-12-13 17:50 ` Florian Weimer
2021-12-13 2:51 ` [PATCH v6 2/2] Add a testcase to check alignment of PT_LOAD segment Rongwei Wang
2021-12-14 2:03 ` [PATCH v6 0/2] fix p_align on PT_LOAD segment in DSO isn't honored Fangrui Song
2021-12-14 3:56 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7bczq0q.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=gavin.dg@linux.alibaba.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=rongwei.wang@linux.alibaba.com \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).