From: "H.J. Lu" <hjl.tools@gmail.com>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: [PATCH v9 2/3] elf: Add a test for PT_LOAD segments with p_align == 1 [BZ #28688]
Date: Fri, 21 Jan 2022 13:12:04 -0800 [thread overview]
Message-ID: <20220121211205.268178-3-hjl.tools@gmail.com> (raw)
In-Reply-To: <20220121211205.268178-1-hjl.tools@gmail.com>
Add tst-p_alignmod2-edit to edit the copy of tst-p_alignmod-base.so to
set p_align of the first PT_LOAD segment to 1 and verify that the shared
library can be loaded normally.
---
elf/Makefile | 13 +++++++++++++
elf/tst-p_align2.c | 27 +++++++++++++++++++++++++++
elf/tst-p_alignmod2-edit.c | 27 +++++++++++++++++++++++++++
3 files changed, 67 insertions(+)
create mode 100644 elf/tst-p_align2.c
create mode 100644 elf/tst-p_alignmod2-edit.c
diff --git a/elf/Makefile b/elf/Makefile
index cdb41c686e..c63abab44b 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -413,7 +413,9 @@ tests += \
tst-noload \
tst-null-argv \
tst-p_alignmod1-edit \
+ tst-p_alignmod2-edit \
tst-p_align1 \
+ tst-p_align2 \
tst-relsort1 \
tst-ro-dynamic \
tst-rtld-run-static \
@@ -2595,3 +2597,14 @@ $(objpfx)tst-p_alignmod1.so: $(objpfx)tst-p_alignmod1-edit \
cp $(objpfx)tst-p_alignmod-base.so $@
$(test-wrapper-env) $(run-program-env) $(rtld-prefix) \
$(objpfx)tst-p_alignmod1-edit $@
+
+$(objpfx)tst-p_align2: $(objpfx)tst-p_alignmod2.so
+
+# Make a copy of tst-p_alignmod-base.so and update p_align of the first
+# PT_LOAD segment.
+$(objpfx)tst-p_alignmod2.so: $(objpfx)tst-p_alignmod2-edit \
+ $(objpfx)tst-p_alignmod-base.so
+ rm -f $@
+ cp $(objpfx)tst-p_alignmod-base.so $@
+ $(test-wrapper-env) $(run-program-env) $(rtld-prefix) \
+ $(objpfx)tst-p_alignmod2-edit $@
diff --git a/elf/tst-p_align2.c b/elf/tst-p_align2.c
new file mode 100644
index 0000000000..961c7fbbf1
--- /dev/null
+++ b/elf/tst-p_align2.c
@@ -0,0 +1,27 @@
+/* Check different alignments of PT_LOAD segments in a shared library.
+ Copyright (C) 2022 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include "tst-p_align.h"
+
+static int
+do_test (void)
+{
+ return do_load_test ();
+}
+
+#include <support/test-driver.c>
diff --git a/elf/tst-p_alignmod2-edit.c b/elf/tst-p_alignmod2-edit.c
new file mode 100644
index 0000000000..4c2ae65b4e
--- /dev/null
+++ b/elf/tst-p_alignmod2-edit.c
@@ -0,0 +1,27 @@
+/* Set p_align of the first PT_LOAD segment to 1.
+ Copyright (C) 2022 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include "tst-elf-edit.h"
+
+/* Set p_align to 1. */
+
+static size_t
+update_p_align (size_t p_align __attribute__ ((unused)))
+{
+ return 1;
+}
--
2.34.1
next prev parent reply other threads:[~2022-01-21 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 21:12 [PATCH v9 0/3] Add p_align tests for PT_LOAD segments H.J. Lu
2022-01-21 21:12 ` [PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676] H.J. Lu
2022-01-24 14:16 ` Adhemerval Zanella
2022-01-24 21:21 ` Joseph Myers
2022-01-25 11:33 ` Adhemerval Zanella
2022-01-26 10:02 ` Florian Weimer
2022-01-21 21:12 ` H.J. Lu [this message]
2022-01-24 14:16 ` [PATCH v9 2/3] elf: Add a test for PT_LOAD segments with p_align == 1 [BZ #28688] Adhemerval Zanella
2022-01-21 21:12 ` [PATCH v9 3/3] elf: Add a test for PT_LOAD segments with invalid p_align " H.J. Lu
2022-01-24 14:17 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121211205.268178-3-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).