From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676]
Date: Wed, 26 Jan 2022 11:02:06 +0100 [thread overview]
Message-ID: <87bkzyvmqp.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <945e3c11-1285-2227-faa3-ce5e764fc3ff@linaro.org> (Adhemerval Zanella's message of "Tue, 25 Jan 2022 08:33:18 -0300")
* Adhemerval Zanella:
> On 24/01/2022 18:21, Joseph Myers wrote:
>> On Mon, 24 Jan 2022, Adhemerval Zanella via Libc-alpha wrote:
>>
>>>> +# Make a copy of tst-p_alignmod-base.so and lower p_align of the first
>>>> +# PT_LOAD segment.
>>>> +$(objpfx)tst-p_alignmod1.so: $(objpfx)tst-p_alignmod1-edit \
>>>> + $(objpfx)tst-p_alignmod-base.so
>>>> + rm -f $@
>>>> + cp $(objpfx)tst-p_alignmod-base.so $@
>>>> + $(test-wrapper-env) $(run-program-env) $(rtld-prefix) \
>>>> + $(objpfx)tst-p_alignmod1-edit $@
>>
>> This has broken the testsuite build for all cross-compilation situations
>> not running the newly built tests. You can't run a program built with the
>> new glibc unless $(run-built-tests) is yes. Either disable everything
>> depending on running these programs unless $(run-built-tests) is yes or
>> revert the commits adding them (reimplementing the editing in Python using
>> only the standard library might be a possibility for the future; building
>> the C program for $build wouldn't be a good idea and we'd like to phase
>> out the remaining two tests that do use C programs for $build by subsuming
>> them in conformtest).
>>
>
> I forgot about this issue and reimplementing using pythong seems a better
> approach. I will work on this.
Can we revert the test addition in the meantime? It's making validation
of other changes complicated.
Thanks,
Florian
next prev parent reply other threads:[~2022-01-26 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 21:12 [PATCH v9 0/3] Add p_align tests for PT_LOAD segments H.J. Lu
2022-01-21 21:12 ` [PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676] H.J. Lu
2022-01-24 14:16 ` Adhemerval Zanella
2022-01-24 21:21 ` Joseph Myers
2022-01-25 11:33 ` Adhemerval Zanella
2022-01-26 10:02 ` Florian Weimer [this message]
2022-01-21 21:12 ` [PATCH v9 2/3] elf: Add a test for PT_LOAD segments with p_align == 1 [BZ #28688] H.J. Lu
2022-01-24 14:16 ` Adhemerval Zanella
2022-01-21 21:12 ` [PATCH v9 3/3] elf: Add a test for PT_LOAD segments with invalid p_align " H.J. Lu
2022-01-24 14:17 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkzyvmqp.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).