public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: libc-alpha@sourceware.org
Cc: joseph@codesourcery.com
Subject: [PATCH] tst-realpath-toolong: Fix hurd build
Date: Sat, 22 Jan 2022 20:15:23 +0530	[thread overview]
Message-ID: <20220122144523.2221584-1-siddhesh@sourceware.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2201212321551.199290@digraph.polyomino.org.uk>

We don't really need a bigger buffer for realpath since it should fail
and return NULL.  In the bug too, the buffer itself is not accessed; it
is in fact left untouched.  Drop the PATH_MAX use and pass a single char
address.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
---
 stdlib/tst-realpath-toolong.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/stdlib/tst-realpath-toolong.c b/stdlib/tst-realpath-toolong.c
index 8bed772460..ed84787a32 100644
--- a/stdlib/tst-realpath-toolong.c
+++ b/stdlib/tst-realpath-toolong.c
@@ -34,8 +34,8 @@ do_test (void)
 {
   char *base = support_create_and_chdir_toolong_temp_directory (BASENAME);
 
-  char buf[PATH_MAX + 1];
-  const char *res = realpath (".", buf);
+  char buf;
+  const char *res = realpath (".", &buf);
 
   /* canonicalize.c states that if the real path is >= PATH_MAX, then
      realpath returns NULL and sets ENAMETOOLONG.  */
-- 
2.34.1


  parent reply	other threads:[~2022-01-22 14:45 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19  8:21 [PATCH v2 0/3] Fixes for CVE-2021-3998 and CVE-2021-3999 Siddhesh Poyarekar
2022-01-19  8:21 ` [PATCH v2 1/3] support: Add helpers to create paths longer than PATH_MAX Siddhesh Poyarekar
2022-01-19 10:13   ` Siddhesh Poyarekar
2022-01-20 14:47     ` Cristian Rodríguez
2022-01-20 14:56       ` Florian Weimer
2022-01-20 15:17         ` Cristian Rodríguez
2022-01-20 14:57       ` Siddhesh Poyarekar
2022-01-19  8:21 ` [PATCH v2 2/3] realpath: Set errno to ENAMETOOLONG for result larger than PATH_MAX (CVE-2021-3998) Siddhesh Poyarekar
2022-01-19  8:21 ` [PATCH v2 3/3] getcwd: Set errno to ERANGE for size == 1 (CVE-2021-3999) Siddhesh Poyarekar
2022-01-20  9:32 ` [PATCH v3 0/3] Fixes for CVE-2021-3998 and CVE-2021-3999 Siddhesh Poyarekar
2022-01-20  9:32   ` [PATCH v3 1/3] support: Add helpers to create paths longer than PATH_MAX Siddhesh Poyarekar
2022-01-21 16:27     ` Adhemerval Zanella
2022-01-20  9:32   ` [PATCH v3 2/3] realpath: Set errno to ENAMETOOLONG for result larger than PATH_MAX [BZ #28770] Siddhesh Poyarekar
2022-01-21 23:22     ` Joseph Myers
2022-01-22  3:47       ` Siddhesh Poyarekar
2022-01-22 14:45       ` Siddhesh Poyarekar [this message]
2022-01-23  0:36         ` [PATCH] tst-realpath-toolong: Fix hurd build Samuel Thibault
2022-01-23 15:19           ` Siddhesh Poyarekar
2022-01-23 15:33             ` Samuel Thibault
2022-01-24  6:00               ` [committed v2] " Siddhesh Poyarekar
2022-01-24 13:45     ` [PATCH v3 2/3] realpath: Set errno to ENAMETOOLONG for result larger than PATH_MAX [BZ #28770] Andreas Schwab
2022-01-24 14:25       ` Siddhesh Poyarekar
2022-01-24 14:48         ` Andreas Schwab
2022-01-24 14:59           ` Siddhesh Poyarekar
2022-01-24 15:28             ` Andreas Schwab
2022-01-24 16:08               ` [committed] realpath: Avoid overwriting preexisting error (CVE-2021-3998) Siddhesh Poyarekar
2022-01-20  9:32   ` [PATCH v3 3/3] getcwd: Set errno to ERANGE for size == 1 (CVE-2021-3999) Siddhesh Poyarekar
2022-01-20 13:32     ` Andreas Schwab
2022-01-21 16:41     ` Adhemerval Zanella
2022-01-21 17:26       ` Siddhesh Poyarekar
2022-01-21 17:31         ` Adhemerval Zanella
2022-01-21 17:38       ` [PATCH v4] " Siddhesh Poyarekar
2022-01-21 17:59         ` Andreas Schwab
2022-01-21 18:02           ` Siddhesh Poyarekar
2022-01-21 18:04       ` [PATCH v5] " Siddhesh Poyarekar
2022-01-24  6:03         ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220122144523.2221584-1-siddhesh@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).