* [PATCH] x86-64: Remove bzero weak alias in SS2 memset
@ 2022-02-10 19:52 H.J. Lu
2022-02-14 16:17 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2022-02-10 19:52 UTC (permalink / raw)
To: libc-alpha
commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Feb 7 05:55:15 2022 -0800
x86-64: Optimize bzero
added the optimized bzero. Remove bzero weak alias in SS2 memset to
avoid undefined __bzero in memset-sse2-unaligned-erms.
---
sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
index 329c58ee46..d52d170804 100644
--- a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
+++ b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
@@ -31,9 +31,7 @@
# endif
# undef weak_alias
-# define weak_alias(original, alias) \
- .weak bzero; bzero = __bzero
-
+# define weak_alias(original, alias)
# undef strong_alias
# define strong_alias(ignored1, ignored2)
#endif
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86-64: Remove bzero weak alias in SS2 memset
2022-02-10 19:52 [PATCH] x86-64: Remove bzero weak alias in SS2 memset H.J. Lu
@ 2022-02-14 16:17 ` H.J. Lu
2022-05-12 19:23 ` Sunil Pandey
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2022-02-14 16:17 UTC (permalink / raw)
To: GNU C Library
On Thu, Feb 10, 2022 at 11:52 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Mon Feb 7 05:55:15 2022 -0800
>
> x86-64: Optimize bzero
>
> added the optimized bzero. Remove bzero weak alias in SS2 memset to
> avoid undefined __bzero in memset-sse2-unaligned-erms.
> ---
> sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> index 329c58ee46..d52d170804 100644
> --- a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> +++ b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> @@ -31,9 +31,7 @@
> # endif
>
> # undef weak_alias
> -# define weak_alias(original, alias) \
> - .weak bzero; bzero = __bzero
> -
> +# define weak_alias(original, alias)
> # undef strong_alias
> # define strong_alias(ignored1, ignored2)
> #endif
> --
> 2.34.1
>
I am checking in this patch.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86-64: Remove bzero weak alias in SS2 memset
2022-02-14 16:17 ` H.J. Lu
@ 2022-05-12 19:23 ` Sunil Pandey
0 siblings, 0 replies; 3+ messages in thread
From: Sunil Pandey @ 2022-05-12 19:23 UTC (permalink / raw)
To: H.J. Lu, Libc-stable Mailing List; +Cc: GNU C Library
On Mon, Feb 14, 2022 at 8:18 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Thu, Feb 10, 2022 at 11:52 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date: Mon Feb 7 05:55:15 2022 -0800
> >
> > x86-64: Optimize bzero
> >
> > added the optimized bzero. Remove bzero weak alias in SS2 memset to
> > avoid undefined __bzero in memset-sse2-unaligned-erms.
> > ---
> > sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> > index 329c58ee46..d52d170804 100644
> > --- a/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> > +++ b/sysdeps/x86_64/multiarch/memset-sse2-unaligned-erms.S
> > @@ -31,9 +31,7 @@
> > # endif
> >
> > # undef weak_alias
> > -# define weak_alias(original, alias) \
> > - .weak bzero; bzero = __bzero
> > -
> > +# define weak_alias(original, alias)
> > # undef strong_alias
> > # define strong_alias(ignored1, ignored2)
> > #endif
> > --
> > 2.34.1
> >
>
> I am checking in this patch.
>
> --
> H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-12 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 19:52 [PATCH] x86-64: Remove bzero weak alias in SS2 memset H.J. Lu
2022-02-14 16:17 ` H.J. Lu
2022-05-12 19:23 ` Sunil Pandey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).