Monday Patch Queue Review update (2022-03-28)

Monday Patch Queue Review update (2022-03-28)

[Carlos O'Donell]

Most recent meeting status is always here:
https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update

Meeting: 2022-03-28 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

 * State NEW, delegate NOBODY is 312 patches.
 * Adhemerval tries to push.
  "Enumerating objects: 1581, done.
Counting objects: 100% (1581/1581), done.
Delta compression using up to 24 threads
Compressing objects: 100% (807/807), done.
Writing objects: 100% (1093/1093), 162.32 KiB | 13.53 MiB/s, done.
Total 1093 (delta 950), reused 298 (delta 272), pack-reused 0
remote: Resolving deltas: 100% (950/950), completed with 415 local objects.
remote: *** This update introduces too many new commits (121), which would
remote: *** trigger as many emails, exceeding the current limit (100).
remote: *** Contact your repository adminstrator if you really meant
remote: *** to generate this many commit emails.
remote: error: hook declined to update refs/heads/azanella/clang"
 * Carlos reviewed and it's max-commit-emails, which can be set to 1000 to avoid
   this problem and allow you to publish a branch for review.
 * [v2] nptl: Add backoff mechanism to spinlock loop (Wangyang Guo)
  * We can't use random-bits.h (30 cycles)
  * Can we use tid?
  * Can we use rdtsc? (18 cycles)
  * At least one microbench should be contributed.
 * [v1,1/2] x86: Small improvements for wcscpy-ssse3 (Noah)
  * Waiting for feedback from Zhaoxin cpu discussion, see:
    https://sourceware.org/pipermail/libc-alpha/2022-March/137354.html
 * [v2,1/6] x86: Remove {w}memcmp-ssse3 (Noah)
  * HJ reviewing.
 * rwlock for async application
  * This is an RFC for glibc to deviate from POSIX behaviour.
 * Add HWCAP2_AFP, HWCAP2_RPRES from Linux 5.17 to AArch64 bits/hwcap.h (Joseph)
  * Accepted by Szabolcs [Arm]
 * Note from Adhemvarl that POSIX will add strlcpy and strlcat
  * Prposed by Florian in 2016.
  * https://www.austingroupbugs.net/view.php?id=986
  * https://sourceware.org/glibc/wiki/strlcpy
 * Stopped at 52304.
 * realpath: Bring back GNU extension on ENOENT and EACCES [BZ #28996]
  * Adhemerval will review.
 * [v5] Allow for unpriviledged nested containers
  * Adhemerval asking if we are going to accept this patch?
  * Carlos to review this to completion to unblock Adhemerval.
  * This blocks the syslog https://patchwork.sourceware.org/project/glibc/list/?series=8031
 * Siddhesh notes that DNS tests no longer depend on proc mount.
  * However we still have tests that use DNS and can fail.
  * They need to be ported to use the in-process test DNS resolver or changed.
 * Support DT_RELR relative relocation format review.
  * What is the status of DT_RELR for AArch64? Currently unimplemented.
  * Looking for review of v6 patches.
  * No technical blockers. Push April 11th if no further reviews.

-- 
Cheers,
Carlos.

Re: Monday Patch Queue Review update (2022-03-28)

[Fangrui Song]

On 2022-03-29, Carlos O'Donell via Libc-alpha wrote:
>Most recent meeting status is always here:
>https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update
>
>Meeting: 2022-03-28 @ 0900h EST5EDT
>
>Video/Audio: https://bluejeans.com/9093064454
>
>IRC: #glibc on OFTC.
>
>Review new patches and restart review at the top.
>
> * State NEW, delegate NOBODY is 312 patches.
> * Adhemerval tries to push.
>  "Enumerating objects: 1581, done.
>Counting objects: 100% (1581/1581), done.
>Delta compression using up to 24 threads
>Compressing objects: 100% (807/807), done.
>Writing objects: 100% (1093/1093), 162.32 KiB | 13.53 MiB/s, done.
>Total 1093 (delta 950), reused 298 (delta 272), pack-reused 0
>remote: Resolving deltas: 100% (950/950), completed with 415 local objects.
>remote: *** This update introduces too many new commits (121), which would
>remote: *** trigger as many emails, exceeding the current limit (100).
>remote: *** Contact your repository adminstrator if you really meant
>remote: *** to generate this many commit emails.
>remote: error: hook declined to update refs/heads/azanella/clang"
> * Carlos reviewed and it's max-commit-emails, which can be set to 1000 to avoid
>   this problem and allow you to publish a branch for review.
> * [v2] nptl: Add backoff mechanism to spinlock loop (Wangyang Guo)
>  * We can't use random-bits.h (30 cycles)
>  * Can we use tid?
>  * Can we use rdtsc? (18 cycles)
>  * At least one microbench should be contributed.
> * [v1,1/2] x86: Small improvements for wcscpy-ssse3 (Noah)
>  * Waiting for feedback from Zhaoxin cpu discussion, see:
>    https://sourceware.org/pipermail/libc-alpha/2022-March/137354.html
> * [v2,1/6] x86: Remove {w}memcmp-ssse3 (Noah)
>  * HJ reviewing.
> * rwlock for async application
>  * This is an RFC for glibc to deviate from POSIX behaviour.
> * Add HWCAP2_AFP, HWCAP2_RPRES from Linux 5.17 to AArch64 bits/hwcap.h (Joseph)
>  * Accepted by Szabolcs [Arm]
> * Note from Adhemvarl that POSIX will add strlcpy and strlcat
>  * Prposed by Florian in 2016.
>  * https://www.austingroupbugs.net/view.php?id=986
>  * https://sourceware.org/glibc/wiki/strlcpy
> * Stopped at 52304.
> * realpath: Bring back GNU extension on ENOENT and EACCES [BZ #28996]
>  * Adhemerval will review.
> * [v5] Allow for unpriviledged nested containers
>  * Adhemerval asking if we are going to accept this patch?
>  * Carlos to review this to completion to unblock Adhemerval.
>  * This blocks the syslog https://patchwork.sourceware.org/project/glibc/list/?series=8031
> * Siddhesh notes that DNS tests no longer depend on proc mount.
>  * However we still have tests that use DNS and can fail.
>  * They need to be ported to use the in-process test DNS resolver or changed.
> * Support DT_RELR relative relocation format review.
>  * What is the status of DT_RELR for AArch64? Currently unimplemented.

For ld.lld, -z pack-relative-relocs is supported on all ports it
supports, including arm, aarch64, mips, powerpc32, powerpc64, riscv,
x86-32, x86-64.  I did not rush for the LLD 14.x release. Testing can be
dome with lld built from the main branch.

Looking forward to patches to GNU ld for aarch64 (and other ports) :-)

>  * Looking for review of v6 patches.
>  * No technical blockers. Push April 11th if no further reviews.
>
>-- 
>Cheers,
>Carlos.
>