public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Xiaoming Ni <nixiaoming@huawei.com>
To: <drepper@redhat.com>, <lukma@denx.de>,
	<adrian.ratiu@collabora.com>, <schwab@linux-m68k.org>,
	<fweimer@redhat.com>, <adhemerval.zanella@linaro.org>,
	<siddhesh@sourceware.org>
Cc: <nixiaoming@huawei.com>, <wangle6@huawei.com>,
	<libc-alpha@sourceware.org>
Subject: [PATCH v2 0/4] time: Use __nonnull to avoid null pointer
Date: Thu, 5 May 2022 11:01:07 +0800	[thread overview]
Message-ID: <20220505030111.111197-1-nixiaoming@huawei.com> (raw)
In-Reply-To: <20220428122529.108208-1-nixiaoming@huawei.com>

Some external interface codes do not check whether the pointer parameter
 is null. If the parameter is null, the program crashes (BZ#27662).
Therefore, add a __nonull statement to the function declaration to avoid
 null pointers.

Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27662
Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29084

The __nonull declaration is added for the following interfaces:
	adjtimex()
	adjtimex64()
	ntp_gettime()
	ntp_gettime64()
	ntp_gettimex()
	ntp_gettimex64()
	ntp_adjtime()
	clock_settime()
	clock_settime64()
	clock_gettime()
	clock_gettime64()
	clock_adjtime()
	clock_adjtime64()
--
v2:
  fix the compilation error caused by missing semicolons.
  Thanks Siddhesh Poyarekar for the review.
v1: https://public-inbox.org/libc-alpha/20220428122529.108208-1-nixiaoming@huawei.com/

--

Xiaoming Ni (4):
  adjtimex/adjtimex64: Use __nonnull to avoid null pointer
  ntp_xxxtimex: Use __nonnull to avoid null pointer
  clock_adjtime: Use __nonnull to avoid null pointer
  clock_settime/clock_gettime: Use __nonnull to avoid null pointer

 include/time.h                              |  4 ++--
 sysdeps/unix/sysv/linux/bits/time.h         |  4 ++--
 sysdeps/unix/sysv/linux/include/sys/timex.h | 10 +++++-----
 sysdeps/unix/sysv/linux/sys/timex.h         | 16 ++++++++--------
 time/time.h                                 | 11 +++++++----
 5 files changed, 24 insertions(+), 21 deletions(-)

-- 
2.27.0


  parent reply	other threads:[~2022-05-05  3:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 12:25 [PATCH " Xiaoming Ni
2022-04-28 12:25 ` [PATCH 1/4] adjtimex/adjtimex64: " Xiaoming Ni
2022-05-04 10:56   ` Siddhesh Poyarekar
2022-04-28 12:25 ` [PATCH 2/4] ntp_xxxtimex: " Xiaoming Ni
2022-05-04 10:59   ` Siddhesh Poyarekar
2022-04-28 12:25 ` [PATCH 3/4] clock_adjtime: " Xiaoming Ni
2022-05-04 11:00   ` Siddhesh Poyarekar
2022-04-28 12:25 ` [PATCH 4/4] clock_settime/clock_gettime: " Xiaoming Ni
2022-05-04 11:02   ` Siddhesh Poyarekar
2022-05-05  1:39     ` Xiaoming Ni
2022-05-05  3:01 ` Xiaoming Ni [this message]
2022-05-05  3:01   ` [PATCH v2 1/4] adjtimex/adjtimex64: " Xiaoming Ni
2022-05-05  3:01   ` [PATCH v2 2/4] ntp_xxxtimex: " Xiaoming Ni
2022-05-05  3:01   ` [PATCH v2 3/4] clock_adjtime: " Xiaoming Ni
2022-05-05  3:01   ` [PATCH v2 4/4] clock_settime/clock_gettime: " Xiaoming Ni
2022-05-05  4:26     ` Siddhesh Poyarekar
2022-05-05  8:23       ` Xiaoming Ni
2022-05-05 12:26         ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505030111.111197-1-nixiaoming@huawei.com \
    --to=nixiaoming@huawei.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=adrian.ratiu@collabora.com \
    --cc=drepper@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    --cc=schwab@linux-m68k.org \
    --cc=siddhesh@sourceware.org \
    --cc=wangle6@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).