From: Fangrui Song <maskray@google.com>
To: Nicholas Guriev <nicholas@guriev.su>
Cc: Siddhesh Poyarekar <siddhesh@gotplt.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3] elf: Rewrite long RESOLVE_MAP macro to a debug friendly function
Date: Sat, 14 May 2022 15:48:49 -0700 [thread overview]
Message-ID: <20220514224849.d7isxwcxnxoo3jhc@google.com> (raw)
In-Reply-To: <c5d51b0d0dff8467d820d7e406296311927bf81d.camel@guriev.su>
On 2022-05-14, Nicholas Guriev wrote:
>On Пн, 2022-05-09 at 19:08 +0530, Siddhesh Poyarekar wrote:
>> Please use __always_inline instead, which adds the inline keyword as
>> well as __attribute__ ((inline)). That way gcc ensures that the
>> function is *always* inlined.
>
>That is not necessary. My original intention was to improve the
>debugging experience at this point. And the standard `inline` keyword
>allows one to control optimizations with the -O flag.
>
Looks good to me, I think the always_inline here does not affect
performance, as shown in my testing with a large PIE with many
R_*_RELATIVE (function call overhead is larger with a non-R_*_RELATIVE).
I will wait a bit and can push the commit in case Nicholas does not have
write access.
Reviewed-by: Fangrui Song <maskray@google.com>
next prev parent reply other threads:[~2022-05-14 22:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 14:51 [PATCH] " Nicholas Guriev
2022-05-02 21:20 ` Fangrui Song
2022-05-03 10:04 ` Nicholas Guriev
2022-05-03 20:12 ` Fāng-ruì Sòng
2022-05-07 13:33 ` [PATCH v3] " Nicholas Guriev
2022-05-09 13:38 ` Siddhesh Poyarekar
2022-05-14 14:27 ` Nicholas Guriev
2022-05-14 22:48 ` Fangrui Song [this message]
2022-05-15 0:58 ` Siddhesh Poyarekar
2022-05-22 22:24 ` Fangrui Song
2022-05-23 7:28 ` Siddhesh Poyarekar
2022-05-23 12:35 ` Adhemerval Zanella
2022-05-23 13:02 ` Siddhesh Poyarekar
2022-05-23 16:22 ` Adhemerval Zanella
2022-05-23 16:33 ` Siddhesh Poyarekar
2022-05-23 16:56 ` Adhemerval Zanella
2022-05-03 19:14 ` [PATCH v2] " Nicholas Guriev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514224849.d7isxwcxnxoo3jhc@google.com \
--to=maskray@google.com \
--cc=libc-alpha@sourceware.org \
--cc=nicholas@guriev.su \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).