Re: [PATCH v3] elf: Rewrite long RESOLVE_MAP macro to a debug friendly function

[Siddhesh Poyarekar <siddhesh@gotplt.org>]

On 23/05/2022 21:52, Adhemerval Zanella wrote:
>  From ed159672eb3cd650a32b7e5cb4d5ec1fe0e63802 I take that even always_inline
> might fail for some reason.  So we need to keep using always_inline on function
> that need to be inline to get a compiler warning if it can not be done.
> 
> I think by using -Winline with stardand C99 static inline, besides being
> slight more portable code is also less error prone (since it is one less
> annotation to take care of).  It would be slight better to setup -Winline
> per TU, instead of global since we only need always_inline semantic for
> specific usages.
> 
> In the end I think both a pretty equivalent.

That is surprising, and kinda defeats the "always" in the always_inline. 
  The documentation for the attribute also states that failure to inline 
a function is diagnosed as an error[1], except when the function is 
called indirectly and maybe some more context is needed for 
ed159672eb3cd650a32b7e5cb4d5ec1fe0e63802 to understand the nature of the 
warnings.

So I can't agree yet that it's equivalent, but I do agree that the 
always_inline semantic is for specific use cases.

Thanks,
Siddhesh

[1] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html