From: Aurelien Jarno <aurelien@aurel32.net>
To: libc-alpha@sourceware.org
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [PATCH] linux: Fix fstatat with !XSTAT_IS_XSTAT64 and __TIMESIZE=64 (BZ #29730)
Date: Fri, 28 Oct 2022 22:54:40 +0200 [thread overview]
Message-ID: <20221028205440.1091298-1-aurelien@aurel32.net> (raw)
Commit 6e8a0aac2f883 ("time: Fix overflow itimer tests on 32-bit
systems") changed in_time_t_range to assume a 32-bit time_t. Therefore
stop calling it from __fstatat for systems with 64-bit time_t.
Resolves: BZ #29730
---
sysdeps/unix/sysv/linux/fstatat.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/fstatat.c b/sysdeps/unix/sysv/linux/fstatat.c
index 055fb4762e..afe93b6cf4 100644
--- a/sysdeps/unix/sysv/linux/fstatat.c
+++ b/sysdeps/unix/sysv/linux/fstatat.c
@@ -33,9 +33,13 @@ __fstatat (int fd, const char *file, struct stat *buf, int flag)
if (! in_ino_t_range (st64.st_ino)
|| ! in_off_t_range (st64.st_size)
|| ! in_blkcnt_t_range (st64.st_blocks)
+/* in_time_t_range assumes that all usages are for sizeof(time_t) == 32. */
+# if __TIMESIZE != 64
|| ! in_time_t_range (st64.st_atim.tv_sec)
|| ! in_time_t_range (st64.st_mtim.tv_sec)
- || ! in_time_t_range (st64.st_ctim.tv_sec))
+ || ! in_time_t_range (st64.st_ctim.tv_sec)
+# endif
+ )
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EOVERFLOW);
/* Clear internal pad and reserved fields. */
--
2.35.1
next reply other threads:[~2022-10-28 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:54 Aurelien Jarno [this message]
2022-10-31 16:03 ` Adhemerval Zanella Netto
2022-10-31 17:25 ` Adhemerval Zanella Netto
2022-10-31 22:20 ` Aurelien Jarno
2022-11-01 10:55 ` Aurelien Jarno
2022-11-01 11:57 ` Aurelien Jarno
2022-11-01 12:40 ` Adhemerval Zanella Netto
2022-11-01 21:31 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028205440.1091298-1-aurelien@aurel32.net \
--to=aurelien@aurel32.net \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).