Re: [PATCH] linux: Fix fstatat with !XSTAT_IS_XSTAT64 and __TIMESIZE=64 (BZ #29730)

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 31/10/22 13:03, Adhemerval Zanella Netto wrote:
> 
> 
> On 28/10/22 17:54, Aurelien Jarno wrote:
>> Commit 6e8a0aac2f883 ("time: Fix overflow itimer tests on 32-bit
>> systems") changed in_time_t_range to assume a 32-bit time_t. Therefore
>> stop calling it from __fstatat for systems with 64-bit time_t.
>>
>> Resolves: BZ #29730
> 
> Although this change is not incorrect, I think the fix I just sent [1] is 
> slight better because it just alias non-LFS stat to LFS stat for mips 
> (which is also a small runtime and code optimization), while avoiding 
> touching generic code (so we need to check if trigger another issue on 
> different architecture).
> 
> [1] https://sourceware.org/pipermail/libc-alpha/2022-October/143089.html

So I was wrong that we can assume stat and stat64 are equal on mips.  Maybe
instead of adding the fix on stat we can make it more generic and move it
to is_time_t_range (so it can potentially fix usage not only on stat code)
as my comment on https://sourceware.org/bugzilla/show_bug.cgi?id=29730 ?