* [PATCH v2 0/3] htl: move some symbols into libc
@ 2023-01-04 8:49 Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 1/3] htl: move __pthtread_total " Guy-Fleury Iteriteka
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Guy-Fleury Iteriteka @ 2023-01-04 8:49 UTC (permalink / raw)
To: libc-alpha
moved __pthtread_total, ___pthread_self, pthread_self
Note: This is for review i revisit it when glibc 2.37 is out for 2.38 merge
Guy-Fleury Iteriteka (3):
htl: move __pthtread_total into libc
htl: move ___pthread_self into libc.
htl: move pthread_self into libc
htl/Makefile | 3 +--
htl/Versions | 15 ++++++++++++---
htl/forward.c | 4 ----
htl/pt-create.c | 6 ------
htl/pt-initialize.c | 1 -
htl/pt-internal.h | 1 +
htl/pt-nthreads.c | 23 +++++++++++++++++++++++
htl/pt-self.c | 13 +++++++++++--
sysdeps/htl/pthread-functions.h | 2 --
sysdeps/htl/pthreadP.h | 2 ++
sysdeps/mach/hurd/htl/pt-pthread_self.c | 22 ++++++++++++++++++++++
sysdeps/mach/hurd/htl/pt-sysdep.c | 2 --
sysdeps/mach/hurd/htl/pt-sysdep.h | 3 +++
sysdeps/mach/hurd/i386/libc.abilist | 2 ++
sysdeps/mach/hurd/i386/libpthread.abilist | 2 --
15 files changed, 77 insertions(+), 24 deletions(-)
create mode 100644 htl/pt-nthreads.c
create mode 100644 sysdeps/mach/hurd/htl/pt-pthread_self.c
--
2.38.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] htl: move __pthtread_total into libc
2023-01-04 8:49 [PATCH v2 0/3] htl: move some symbols into libc Guy-Fleury Iteriteka
@ 2023-01-04 8:49 ` Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 2/3] htl: move ___pthread_self " Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 3/3] htl: move pthread_self " Guy-Fleury Iteriteka
2 siblings, 0 replies; 6+ messages in thread
From: Guy-Fleury Iteriteka @ 2023-01-04 8:49 UTC (permalink / raw)
To: libc-alpha
htl/pt-nthreads.c: new file.
htl/Makefile: Add it to routine.
htl/Versions: version it as private libc symbol.
htl/pt-create.c: remove his definition here.
htl/pt-internal.h: add propertie to it declaration.
---
htl/Makefile | 2 +-
htl/Versions | 1 +
htl/pt-create.c | 6 ------
htl/pt-internal.h | 1 +
htl/pt-nthreads.c | 23 +++++++++++++++++++++++
5 files changed, 26 insertions(+), 7 deletions(-)
create mode 100644 htl/pt-nthreads.c
diff --git a/htl/Makefile b/htl/Makefile
index 0b403e2f..61944148 100644
--- a/htl/Makefile
+++ b/htl/Makefile
@@ -164,7 +164,7 @@ headers := \
distribute :=
-routines := forward libc_pthread_init alloca_cutoff htlfreeres
+routines := forward libc_pthread_init alloca_cutoff htlfreeres pt-nthreads
shared-only-routines = forward
extra-libs := libpthread
diff --git a/htl/Versions b/htl/Versions
index 4e0ebac2..113110f4 100644
--- a/htl/Versions
+++ b/htl/Versions
@@ -30,6 +30,7 @@ libc {
__libc_alloca_cutoff;
__libc_pthread_init;
__pthread_cleanup_stack;
+ __pthread_total;
}
}
diff --git a/htl/pt-create.c b/htl/pt-create.c
index 5d37edbb..34a63b6a 100644
--- a/htl/pt-create.c
+++ b/htl/pt-create.c
@@ -36,12 +36,6 @@
# include <locale.h>
#endif
-/* The total number of pthreads currently active. This is defined
- here since it would be really stupid to have a threads-using
- program that doesn't call `pthread_create'. */
-unsigned int __pthread_total;
-\f
-
/* The entry-point for new threads. */
static void
entry_point (struct __pthread *self, void *(*start_routine) (void *), void *arg)
diff --git a/htl/pt-internal.h b/htl/pt-internal.h
index f01cb7ce..b787acf8 100644
--- a/htl/pt-internal.h
+++ b/htl/pt-internal.h
@@ -165,6 +165,7 @@ __pthread_dequeue (struct __pthread *thread)
/* The total number of threads currently active. */
extern unsigned int __pthread_total;
+libc_hidden_proto (__pthread_total)
/* Concurrency hint. */
extern int __pthread_concurrency;
diff --git a/htl/pt-nthreads.c b/htl/pt-nthreads.c
new file mode 100644
index 00000000..9a6140ee
--- /dev/null
+++ b/htl/pt-nthreads.c
@@ -0,0 +1,23 @@
+/* Thread counter variable.
+ Copyright (C) 2021-2023 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <pt-internal.h>
+
+/* Number of threads running. */
+unsigned int __pthread_total;
+libc_hidden_data_def (__pthread_total)
--
2.38.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] htl: move ___pthread_self into libc.
2023-01-04 8:49 [PATCH v2 0/3] htl: move some symbols into libc Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 1/3] htl: move __pthtread_total " Guy-Fleury Iteriteka
@ 2023-01-04 8:49 ` Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 3/3] htl: move pthread_self " Guy-Fleury Iteriteka
2 siblings, 0 replies; 6+ messages in thread
From: Guy-Fleury Iteriteka @ 2023-01-04 8:49 UTC (permalink / raw)
To: libc-alpha
sysdeps/mach/hurd/htl/pt-pthread_self.c: New file.
htl/Makefile: .. Add it to libc routine.
sysdeps/mach/hurd/htl/pt-sysdep.c(__pthread_self): Remove it.
sysdeps/mach/hurd/htl/pt-sysdep.h(__pthread_self): Add hidden propertie.
htl/Versions(__pthread_self) Version it as private symbol.
---
htl/Makefile | 2 +-
htl/Versions | 1 +
sysdeps/mach/hurd/htl/pt-pthread_self.c | 22 ++++++++++++++++++++++
sysdeps/mach/hurd/htl/pt-sysdep.c | 2 --
sysdeps/mach/hurd/htl/pt-sysdep.h | 3 +++
5 files changed, 27 insertions(+), 3 deletions(-)
create mode 100644 sysdeps/mach/hurd/htl/pt-pthread_self.c
diff --git a/htl/Makefile b/htl/Makefile
index 61944148..b569cfcd 100644
--- a/htl/Makefile
+++ b/htl/Makefile
@@ -164,7 +164,7 @@ headers := \
distribute :=
-routines := forward libc_pthread_init alloca_cutoff htlfreeres pt-nthreads
+routines := forward libc_pthread_init alloca_cutoff htlfreeres pt-nthreads pt-pthread_self
shared-only-routines = forward
extra-libs := libpthread
diff --git a/htl/Versions b/htl/Versions
index 113110f4..9ec84811 100644
--- a/htl/Versions
+++ b/htl/Versions
@@ -31,6 +31,7 @@ libc {
__libc_pthread_init;
__pthread_cleanup_stack;
__pthread_total;
+ ___pthread_self;
}
}
diff --git a/sysdeps/mach/hurd/htl/pt-pthread_self.c b/sysdeps/mach/hurd/htl/pt-pthread_self.c
new file mode 100644
index 00000000..c100471b
--- /dev/null
+++ b/sysdeps/mach/hurd/htl/pt-pthread_self.c
@@ -0,0 +1,22 @@
+/* ___pthread_self variable.
+ Copyright (C) 2021-2023 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#include <pt-sysdep.h>
+
+__thread struct __pthread *___pthread_self;
+libc_hidden_tls_def (___pthread_self)
diff --git a/sysdeps/mach/hurd/htl/pt-sysdep.c b/sysdeps/mach/hurd/htl/pt-sysdep.c
index 2d828545..4cd6ba3a 100644
--- a/sysdeps/mach/hurd/htl/pt-sysdep.c
+++ b/sysdeps/mach/hurd/htl/pt-sysdep.c
@@ -26,8 +26,6 @@
#include <pt-internal.h>
#include <pthreadP.h>
-__thread struct __pthread *___pthread_self;
-
static void
reset_pthread_total (void)
{
diff --git a/sysdeps/mach/hurd/htl/pt-sysdep.h b/sysdeps/mach/hurd/htl/pt-sysdep.h
index 854c365c..94d77678 100644
--- a/sysdeps/mach/hurd/htl/pt-sysdep.h
+++ b/sysdeps/mach/hurd/htl/pt-sysdep.h
@@ -19,6 +19,7 @@
#ifndef _PT_SYSDEP_H
#define _PT_SYSDEP_H 1
+#include <stddef.h>
#include <mach.h>
/* XXX */
@@ -32,6 +33,8 @@
mach_msg_header_t wakeupmsg;
extern __thread struct __pthread *___pthread_self;
+libc_hidden_tls_proto (___pthread_self)
+
#ifdef DEBUG
#define _pthread_self() \
({ \
--
2.38.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] htl: move pthread_self into libc
2023-01-04 8:49 [PATCH v2 0/3] htl: move some symbols into libc Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 1/3] htl: move __pthtread_total " Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 2/3] htl: move ___pthread_self " Guy-Fleury Iteriteka
@ 2023-01-04 8:49 ` Guy-Fleury Iteriteka
2023-01-08 19:53 ` Samuel Thibault
2 siblings, 1 reply; 6+ messages in thread
From: Guy-Fleury Iteriteka @ 2023-01-04 8:49 UTC (permalink / raw)
To: libc-alpha
---
htl/Makefile | 3 +--
htl/Versions | 13 ++++++++++---
htl/forward.c | 4 ----
htl/pt-initialize.c | 1 -
htl/pt-self.c | 13 +++++++++++--
sysdeps/htl/pthread-functions.h | 2 --
sysdeps/htl/pthreadP.h | 2 ++
sysdeps/mach/hurd/i386/libc.abilist | 2 ++
sysdeps/mach/hurd/i386/libpthread.abilist | 2 --
9 files changed, 26 insertions(+), 16 deletions(-)
diff --git a/htl/Makefile b/htl/Makefile
index b569cfcd..c75855ad 100644
--- a/htl/Makefile
+++ b/htl/Makefile
@@ -52,7 +52,6 @@ libpthread-routines := pt-attr pt-attr-destroy pt-attr-getdetachstate \
pt-exit \
pt-initialize \
pt-join \
- pt-self \
pt-sigmask \
pt-spin-inlines \
pt-cleanup \
@@ -164,7 +163,7 @@ headers := \
distribute :=
-routines := forward libc_pthread_init alloca_cutoff htlfreeres pt-nthreads pt-pthread_self
+routines := forward libc_pthread_init alloca_cutoff htlfreeres pt-nthreads pt-pthread_self pt-self
shared-only-routines = forward
extra-libs := libpthread
diff --git a/htl/Versions b/htl/Versions
index 9ec84811..e1cb362c 100644
--- a/htl/Versions
+++ b/htl/Versions
@@ -1,4 +1,9 @@
libc {
+ GLIBC_2.12 {
+ pthread_self;
+ __pthread_self;
+ }
+
GLIBC_2.21 {
pthread_attr_destroy; pthread_attr_getdetachstate;
pthread_attr_getinheritsched; pthread_attr_getschedparam;
@@ -26,6 +31,11 @@ libc {
thrd_current; thrd_equal; thrd_sleep; thrd_yield;
}
+ GLIBC_2.37 {
+ pthread_self;
+ __pthread_self;
+ }
+
GLIBC_PRIVATE {
__libc_alloca_cutoff;
__libc_pthread_init;
@@ -119,9 +129,6 @@ libpthread {
pthread_rwlockattr_destroy; pthread_rwlockattr_getpshared;
pthread_rwlockattr_init; pthread_rwlockattr_setpshared;
- pthread_self;
- __pthread_self;
-
pthread_setcancelstate; pthread_setcanceltype;
pthread_setconcurrency; pthread_setschedparam;
pthread_setschedprio; pthread_setspecific;
diff --git a/htl/forward.c b/htl/forward.c
index 00527348..57b0b66c 100644
--- a/htl/forward.c
+++ b/htl/forward.c
@@ -130,10 +130,6 @@ FORWARD (pthread_mutex_lock, (pthread_mutex_t *mutex), (mutex), 0)
FORWARD (pthread_mutex_unlock, (pthread_mutex_t *mutex), (mutex), 0)
-
-FORWARD2 (pthread_self, pthread_t, (void), (), return 0)
-
-
FORWARD (__pthread_setcancelstate, (int state, int *oldstate),
(state, oldstate), 0)
strong_alias (__pthread_setcancelstate, pthread_setcancelstate);
diff --git a/htl/pt-initialize.c b/htl/pt-initialize.c
index 02e6ad6b..fcad3b13 100644
--- a/htl/pt-initialize.c
+++ b/htl/pt-initialize.c
@@ -56,7 +56,6 @@ static const struct pthread_functions pthread_functions = {
.ptr_pthread_mutex_lock = __pthread_mutex_lock,
.ptr_pthread_mutex_trylock = __pthread_mutex_trylock,
.ptr_pthread_mutex_unlock = __pthread_mutex_unlock,
- .ptr_pthread_self = __pthread_self,
.ptr___pthread_setcancelstate = __pthread_setcancelstate,
.ptr_pthread_setcanceltype = __pthread_setcanceltype,
.ptr___pthread_get_cleanup_stack = __pthread_get_cleanup_stack,
diff --git a/htl/pt-self.c b/htl/pt-self.c
index e05ec69b..f8c0b144 100644
--- a/htl/pt-self.c
+++ b/htl/pt-self.c
@@ -17,7 +17,7 @@
<https://www.gnu.org/licenses/>. */
#include <pthread.h>
-
+#include <shlib-compat.h>
#include <pt-internal.h>
/* Return the thread ID of the calling thread. */
@@ -36,4 +36,13 @@ __pthread_self (void)
return self->thread;
}
-weak_alias (__pthread_self, pthread_self);
+libc_hidden_def (__pthread_self)
+versioned_symbol (libc, __pthread_self, pthread_self, GLIBC_2_37);
+
+#if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_12, GLIBC_2_37)
+compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_12);
+#endif
+
+#if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_21, GLIBC_2_37)
+compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_21);
+#endif
diff --git a/sysdeps/htl/pthread-functions.h b/sysdeps/htl/pthread-functions.h
index ccccc8e5..2f0e3df0 100644
--- a/sysdeps/htl/pthread-functions.h
+++ b/sysdeps/htl/pthread-functions.h
@@ -56,7 +56,6 @@ int _pthread_mutex_init (pthread_mutex_t *,
int __pthread_mutex_lock (pthread_mutex_t *);
int __pthread_mutex_trylock (pthread_mutex_t *);
int __pthread_mutex_unlock (pthread_mutex_t *);
-pthread_t __pthread_self (void);
int __pthread_setcancelstate (int, int *);
int __pthread_setcanceltype (int, int *);
struct __pthread_cancelation_handler **__pthread_get_cleanup_stack (void);
@@ -112,7 +111,6 @@ struct pthread_functions
int (*ptr_pthread_mutex_lock) (pthread_mutex_t *);
int (*ptr_pthread_mutex_trylock) (pthread_mutex_t *);
int (*ptr_pthread_mutex_unlock) (pthread_mutex_t *);
- pthread_t (*ptr_pthread_self) (void);
int (*ptr___pthread_setcancelstate) (int, int *);
int (*ptr_pthread_setcanceltype) (int, int *);
struct __pthread_cancelation_handler **(*ptr___pthread_get_cleanup_stack) (void);
diff --git a/sysdeps/htl/pthreadP.h b/sysdeps/htl/pthreadP.h
index 15e937a1..53bf614e 100644
--- a/sysdeps/htl/pthreadP.h
+++ b/sysdeps/htl/pthreadP.h
@@ -92,6 +92,8 @@ int __pthread_attr_setstack (pthread_attr_t *__attr, void *__stackaddr,
int __pthread_attr_getstack (const pthread_attr_t *, void **, size_t *);
void __pthread_testcancel (void);
+libc_hidden_proto (__pthread_self)
+
#if IS_IN (libpthread)
hidden_proto (__pthread_create)
hidden_proto (__pthread_detach)
diff --git a/sysdeps/mach/hurd/i386/libc.abilist b/sysdeps/mach/hurd/i386/libc.abilist
index 4e3200ef..29b08e73 100644
--- a/sysdeps/mach/hurd/i386/libc.abilist
+++ b/sysdeps/mach/hurd/i386/libc.abilist
@@ -28,6 +28,7 @@ GLIBC_2.11 mkostemps F
GLIBC_2.11 mkostemps64 F
GLIBC_2.11 mkstemps F
GLIBC_2.11 mkstemps64 F
+GLIBC_2.12 pthread_self F
GLIBC_2.13 __fentry__ F
GLIBC_2.14 syncfs F
GLIBC_2.15 __fdelt_chk F
@@ -2294,6 +2295,7 @@ GLIBC_2.36 arc4random_buf F
GLIBC_2.36 arc4random_uniform F
GLIBC_2.36 c8rtomb F
GLIBC_2.36 mbrtoc8 F
+GLIBC_2.37 pthread_self F
GLIBC_2.4 __confstr_chk F
GLIBC_2.4 __fgets_chk F
GLIBC_2.4 __fgets_unlocked_chk F
diff --git a/sysdeps/mach/hurd/i386/libpthread.abilist b/sysdeps/mach/hurd/i386/libpthread.abilist
index b9c9b75c..2ef0f670 100644
--- a/sysdeps/mach/hurd/i386/libpthread.abilist
+++ b/sysdeps/mach/hurd/i386/libpthread.abilist
@@ -4,7 +4,6 @@ GLIBC_2.12 __pthread_get_cleanup_stack F
GLIBC_2.12 __pthread_key_create F
GLIBC_2.12 __pthread_kill F
GLIBC_2.12 __pthread_mutex_transfer_np F
-GLIBC_2.12 __pthread_self F
GLIBC_2.12 __pthread_spin_destroy F
GLIBC_2.12 __pthread_spin_init F
GLIBC_2.12 __pthread_spin_lock F
@@ -109,7 +108,6 @@ GLIBC_2.12 pthread_rwlockattr_destroy F
GLIBC_2.12 pthread_rwlockattr_getpshared F
GLIBC_2.12 pthread_rwlockattr_init F
GLIBC_2.12 pthread_rwlockattr_setpshared F
-GLIBC_2.12 pthread_self F
GLIBC_2.12 pthread_setcancelstate F
GLIBC_2.12 pthread_setcanceltype F
GLIBC_2.12 pthread_setconcurrency F
--
2.38.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 3/3] htl: move pthread_self into libc
2023-01-04 8:49 ` [PATCH v2 3/3] htl: move pthread_self " Guy-Fleury Iteriteka
@ 2023-01-08 19:53 ` Samuel Thibault
2023-01-08 20:16 ` Guy-Fleury Iteriteka
0 siblings, 1 reply; 6+ messages in thread
From: Samuel Thibault @ 2023-01-08 19:53 UTC (permalink / raw)
To: Guy-Fleury Iteriteka; +Cc: libc-alpha
Guy-Fleury Iteriteka via Libc-alpha, le mer. 04 janv. 2023 10:49:15 +0200, a ecrit:
> diff --git a/htl/pt-self.c b/htl/pt-self.c
> index e05ec69b..f8c0b144 100644
> --- a/htl/pt-self.c
> +++ b/htl/pt-self.c
> @@ -17,7 +17,7 @@
> <https://www.gnu.org/licenses/>. */
>
> #include <pthread.h>
> -
> +#include <shlib-compat.h>
> #include <pt-internal.h>
>
> /* Return the thread ID of the calling thread. */
> @@ -36,4 +36,13 @@ __pthread_self (void)
> return self->thread;
> }
>
> -weak_alias (__pthread_self, pthread_self);
> +libc_hidden_def (__pthread_self)
> +versioned_symbol (libc, __pthread_self, pthread_self, GLIBC_2_37);
> +
> +#if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_12, GLIBC_2_37)
> +compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_12);
> +#endif
> +#if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_21, GLIBC_2_37)
> +compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_21);
> +#endif
I really believe this one should be
#if SHLIB_COMPAT (libc, GLIBC_2_21, GLIBC_2_37)
compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_21);
#endif
since version 2.21 of pthread_self was already in libc.
> diff --git a/sysdeps/mach/hurd/i386/libc.abilist b/sysdeps/mach/hurd/i386/libc.abilist
> index 4e3200ef..29b08e73 100644
> --- a/sysdeps/mach/hurd/i386/libc.abilist
> +++ b/sysdeps/mach/hurd/i386/libc.abilist
> @@ -28,6 +28,7 @@ GLIBC_2.11 mkostemps F
> GLIBC_2.11 mkostemps64 F
> GLIBC_2.11 mkstemps F
> GLIBC_2.11 mkstemps64 F
> +GLIBC_2.12 pthread_self F
> GLIBC_2.13 __fentry__ F
> GLIBC_2.14 syncfs F
> GLIBC_2.15 __fdelt_chk F
You also need to add __pthread_self which you removed from
libpthread.abilist. Really, run
make -C $src_dir/elf objdir=$PWD subdir=elf ..=../ $PWD/elf/check-abi-libc.out
and see the out file to check that you have gotten them right.
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 3/3] htl: move pthread_self into libc
2023-01-08 19:53 ` Samuel Thibault
@ 2023-01-08 20:16 ` Guy-Fleury Iteriteka
0 siblings, 0 replies; 6+ messages in thread
From: Guy-Fleury Iteriteka @ 2023-01-08 20:16 UTC (permalink / raw)
To: Samuel Thibault; +Cc: libc-alpha
Hello,
On January 8, 2023 9:53:41 PM GMT+02:00, Samuel Thibault <samuel.thibault@aquilenet.fr> wrote:
>Guy-Fleury Iteriteka via Libc-alpha, le mer. 04 janv. 2023 10:49:15 +0200, a ecrit:
>> diff --git a/htl/pt-self.c b/htl/pt-self.c
>> index e05ec69b..f8c0b144 100644
>> --- a/htl/pt-self.c
>> +++ b/htl/pt-self.c
>> @@ -17,7 +17,7 @@
>> <https://www.gnu.org/licenses/>. */
>>
>> #include <pthread.h>
>> -
>> +#include <shlib-compat.h>
>> #include <pt-internal.h>
>>
>> /* Return the thread ID of the calling thread. */
>> @@ -36,4 +36,13 @@ __pthread_self (void)
>> return self->thread;
>> }
>>
>> -weak_alias (__pthread_self, pthread_self);
>> +libc_hidden_def (__pthread_self)
>> +versioned_symbol (libc, __pthread_self, pthread_self, GLIBC_2_37);
>> +
>> +#if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_12, GLIBC_2_37)
>> +compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_12);
>> +#endif
>
>
>
>> +#if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_21, GLIBC_2_37)
>> +compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_21);
>> +#endif
>
>I really believe this one should be
>
>#if SHLIB_COMPAT (libc, GLIBC_2_21, GLIBC_2_37)
>compat_symbol (libc, __pthread_self, pthread_self, GLIBC_2_21);
>#endif
Ok
>
>since version 2.21 of pthread_self was already in libc.
>
>> diff --git a/sysdeps/mach/hurd/i386/libc.abilist b/sysdeps/mach/hurd/i386/libc.abilist
>> index 4e3200ef..29b08e73 100644
>> --- a/sysdeps/mach/hurd/i386/libc.abilist
>> +++ b/sysdeps/mach/hurd/i386/libc.abilist
>> @@ -28,6 +28,7 @@ GLIBC_2.11 mkostemps F
>> GLIBC_2.11 mkostemps64 F
>> GLIBC_2.11 mkstemps F
>> GLIBC_2.11 mkstemps64 F
>> +GLIBC_2.12 pthread_self F
>> GLIBC_2.13 __fentry__ F
>> GLIBC_2.14 syncfs F
>> GLIBC_2.15 __fdelt_chk F
>
>You also need to add __pthread_self which you removed from
>libpthread.abilist. Really, run
>
Ok
>make -C $src_dir/elf objdir=$PWD subdir=elf ..=../ $PWD/elf/check-abi-libc.out
>
>and see the out file to check that you have gotten them right.
Thanks will do that.
>
>Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-08 20:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 8:49 [PATCH v2 0/3] htl: move some symbols into libc Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 1/3] htl: move __pthtread_total " Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 2/3] htl: move ___pthread_self " Guy-Fleury Iteriteka
2023-01-04 8:49 ` [PATCH v2 3/3] htl: move pthread_self " Guy-Fleury Iteriteka
2023-01-08 19:53 ` Samuel Thibault
2023-01-08 20:16 ` Guy-Fleury Iteriteka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).