From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Carlos O'Donell <carlos@redhat.com>
Subject: [PATCH v4 3/6] Linux: Do not align the stack for __clone3
Date: Thu, 12 Jan 2023 10:58:50 -0300 [thread overview]
Message-ID: <20230112135853.3786675-4-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20230112135853.3786675-1-adhemerval.zanella@linaro.org>
All internal callers of __clone3 should provide an already aligned
stack. Removing the stack alignment in __clone3 is a net gain: it
simplifies the internal function contract (mask/unmask signals) along
with the arch-specific code.
Checked on x86_64-linux-gnu.
---
include/clone_internal.h | 3 +
.../sysv/linux/tst-misalign-clone-internal.c | 74 -------------------
sysdeps/unix/sysv/linux/x86_64/clone3.S | 3 -
3 files changed, 3 insertions(+), 77 deletions(-)
delete mode 100644 sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c
diff --git a/include/clone_internal.h b/include/clone_internal.h
index 73b8114df4..f8198d8059 100644
--- a/include/clone_internal.h
+++ b/include/clone_internal.h
@@ -11,6 +11,9 @@
Different than kernel, the implementation also returns EINVAL for an
invalid NULL __CL_ARGS or __FUNC (similar to __clone).
+ All callers are responsible for correctly aligning the stack. The stack is
+ not aligned prior to the syscall (this differs from the exported __clone).
+
This function is only implemented if the ABI defines HAVE_CLONE3_WRAPPER.
*/
extern int __clone3 (struct clone_args *__cl_args, size_t __size,
diff --git a/sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c b/sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c
deleted file mode 100644
index 8b94a74819..0000000000
--- a/sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c
+++ /dev/null
@@ -1,74 +0,0 @@
-/* Verify that __clone_internal properly aligns the child stack.
- Copyright (C) 2021-2023 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library; if not, see
- <https://www.gnu.org/licenses/>. */
-
-#include <sched.h>
-#include <stdbool.h>
-#include <stdint.h>
-#include <stdio.h>
-#include <string.h>
-#include <sys/wait.h>
-#include <unistd.h>
-#include <libc-pointer-arith.h>
-#include <tst-stack-align.h>
-#include <clone_internal.h>
-#include <support/xunistd.h>
-#include <support/check.h>
-
-static int
-check_stack_alignment (void *arg)
-{
- puts ("in f");
-
- return TEST_STACK_ALIGN () ? 1 : 0;
-}
-
-static int
-do_test (void)
-{
- puts ("in do_test");
-
- if (TEST_STACK_ALIGN ())
- FAIL_EXIT1 ("stack isn't aligned\n");
-
-#ifdef __ia64__
-# define STACK_SIZE (256 * 1024)
-#else
-# define STACK_SIZE (128 * 1024)
-#endif
- char st[STACK_SIZE + 1];
- /* NB: Align child stack to 1 byte. */
- char *stack = PTR_ALIGN_UP (&st[0], 2) + 1;
- struct clone_args clone_args =
- {
- .stack = (uintptr_t) stack,
- .stack_size = STACK_SIZE,
- };
- pid_t p = __clone_internal (&clone_args, check_stack_alignment, 0);
-
- /* Clone must not fail. */
- TEST_VERIFY_EXIT (p != -1);
-
- int e;
- xwaitpid (p, &e, __WCLONE);
- TEST_VERIFY (WIFEXITED (e));
- TEST_COMPARE (WEXITSTATUS (e), 0);
-
- return 0;
-}
-
-#include <support/test-driver.c>
diff --git a/sysdeps/unix/sysv/linux/x86_64/clone3.S b/sysdeps/unix/sysv/linux/x86_64/clone3.S
index bd4a834e46..802d56cbac 100644
--- a/sysdeps/unix/sysv/linux/x86_64/clone3.S
+++ b/sysdeps/unix/sysv/linux/x86_64/clone3.S
@@ -73,9 +73,6 @@ L(thread_start):
the outermost frame obviously. */
xorl %ebp, %ebp
- /* Align stack to 16 bytes per the x86-64 psABI. */
- and $-16, %RSP_LP
-
/* Set up arguments for the function call. */
mov %R8_LP, %RDI_LP /* Argument. */
call *%rdx /* Call function. */
--
2.34.1
next prev parent reply other threads:[~2023-01-12 13:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 13:58 [PATCH v4 0/6] Optimize posix_spawn signal setup with clone3 Adhemerval Zanella
2023-01-12 13:58 ` [PATCH v4 1/6] linux: Do not reset signal handler in posix_spawn if it is already SIG_DFL Adhemerval Zanella
2023-01-18 22:24 ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 2/6] linux: Extend internal clone3 documentation Adhemerval Zanella
2023-01-18 22:25 ` Carlos O'Donell
2023-01-12 13:58 ` Adhemerval Zanella [this message]
2023-01-18 22:26 ` [PATCH v4 3/6] Linux: Do not align the stack for __clone3 Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 4/6] linux: Add clone3 CLONE_CLEAR_SIGHAND optimization to posix_spawn Adhemerval Zanella
2023-01-18 22:28 ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 5/6] aarch64: Add the clone3 wrapper Adhemerval Zanella
2023-01-18 22:29 ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 6/6] Linux: optimize clone3 internal usage Adhemerval Zanella
2023-01-18 22:31 ` Carlos O'Donell
2023-01-18 17:53 ` [PATCH v4 0/6] Optimize posix_spawn signal setup with clone3 Adhemerval Zanella Netto
2023-01-18 22:24 ` Carlos O'Donell
2023-01-19 14:39 ` Adhemerval Zanella Netto
2023-01-22 23:21 ` Carlos O'Donell
2023-02-28 16:34 ` H.J. Lu
2023-02-28 17:11 ` Adhemerval Zanella Netto
2023-02-28 18:09 ` Florian Weimer
2023-02-28 18:16 ` Adhemerval Zanella Netto
2023-02-28 19:07 ` H.J. Lu
2023-02-28 21:19 ` Andreas Schwab
2023-02-28 21:31 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112135853.3786675-4-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).