public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 "H.J. Lu" <hjl.tools@gmail.com>,
	 "Carlos O'Donell" <carlos@redhat.com>
Subject: Re: [PATCH v4 0/6] Optimize posix_spawn signal setup with clone3
Date: Tue, 28 Feb 2023 19:09:33 +0100	[thread overview]
Message-ID: <87y1ohll0i.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOqsV+CnSahuA-C8mHkbZuZ-Cynk9QXDiX43Fi=hwv_Vig@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Tue, 28 Feb 2023 08:34:00 -0800")

* H. J. Lu via Libc-alpha:

> On x86-64, I am getting
>
> error: tst-spawn7.c:55: not true: sa.sa_handler == SIG_DFL
> tst-spawn7.c:91: numeric comparison failure
>    left: 1 (0x1); from: WEXITSTATUS (status)
>   right: 0 (0x0); from: 0
> error: tst-spawn7.c:55: not true: sa.sa_handler == SIG_DFL
> tst-spawn7.c:91: numeric comparison failure
>    left: 1 (0x1); from: WEXITSTATUS (status)
>   right: 0 (0x0); from: 0
> error: tst-spawn7.c:71: not true: sa.sa_handler == SIG_DFL
> tst-spawn7.c:91: numeric comparison failure
>    left: 1 (0x1); from: WEXITSTATUS (status)
>   right: 0 (0x0); from: 0
> error: tst-spawn7.c:55: not true: sa.sa_handler == SIG_DFL
> tst-spawn7.c:91: numeric comparison failure
>    left: 1 (0x1); from: WEXITSTATUS (status)
>   right: 0 (0x0); from: 0
> error: 4 test failures
> FAIL: posix/tst-spawn7
>
> with
>
> $ make check -j12
>
> But it passes when I run it by hand.  Is this expected?

I see it as well, but it's not consistent for me, either.  Could it be a
make bug, leaking unusual handler dispositions in some cases?  The test
should probably check that the disposition are as expected at the start,
and not incorrect to begin with.

Thanks,
Florian


  parent reply	other threads:[~2023-02-28 18:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 13:58 Adhemerval Zanella
2023-01-12 13:58 ` [PATCH v4 1/6] linux: Do not reset signal handler in posix_spawn if it is already SIG_DFL Adhemerval Zanella
2023-01-18 22:24   ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 2/6] linux: Extend internal clone3 documentation Adhemerval Zanella
2023-01-18 22:25   ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 3/6] Linux: Do not align the stack for __clone3 Adhemerval Zanella
2023-01-18 22:26   ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 4/6] linux: Add clone3 CLONE_CLEAR_SIGHAND optimization to posix_spawn Adhemerval Zanella
2023-01-18 22:28   ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 5/6] aarch64: Add the clone3 wrapper Adhemerval Zanella
2023-01-18 22:29   ` Carlos O'Donell
2023-01-12 13:58 ` [PATCH v4 6/6] Linux: optimize clone3 internal usage Adhemerval Zanella
2023-01-18 22:31   ` Carlos O'Donell
2023-01-18 17:53 ` [PATCH v4 0/6] Optimize posix_spawn signal setup with clone3 Adhemerval Zanella Netto
2023-01-18 22:24   ` Carlos O'Donell
2023-01-19 14:39     ` Adhemerval Zanella Netto
2023-01-22 23:21       ` Carlos O'Donell
2023-02-28 16:34 ` H.J. Lu
2023-02-28 17:11   ` Adhemerval Zanella Netto
2023-02-28 18:09   ` Florian Weimer [this message]
2023-02-28 18:16     ` Adhemerval Zanella Netto
2023-02-28 19:07       ` H.J. Lu
2023-02-28 21:19     ` Andreas Schwab
2023-02-28 21:31       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1ohll0i.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).