public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joan Bruguera <joanbrugueram@gmail.com>
To: libc-alpha@sourceware.org, 87wn4iqh17.fsf@oldenburg.str.redhat.com
Cc: adhemerval.zanella@linaro.org
Subject: Re: [PATCH v3] elf: Restore ldconfig libc6 implicit soname logic [BZ #30125]
Date: Sat, 18 Feb 2023 22:19:15 +0000	[thread overview]
Message-ID: <20230218221915.3938215-1-joanbrugueram@gmail.com> (raw)
In-Reply-To: <87wn4iqh17.fsf@oldenburg.str.redhat.com>

>> +$CC /dev/null -o $testroot/lib/libsomething.so.1.2.3 -shared
> 
> This links against the system libc and not the libc under test.
> 
> I'd suggest to build another module in elf/Makefile, have
> $(objpfx)tst-ldconfig-no-soname.out depend on it.  This way, it will be
> built before the test script runs.

Thanks, the .so's used in the test don't even need the stdlib anyway,
they could be build with `-nostdlib`, but it's more elegant to build
them in Makefile as you suggest. I have submitted a PATCH v4 with it.

I also took the opportunity to test the complementary scenario,
i.e. that ldconfig indeed creates a symlink for a .so with a soname,
which expands coverage a bit and makes it easier to trust that
the test for the original scenario is working correctly.

             reply	other threads:[~2023-02-18 22:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18 22:19 Joan Bruguera [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-16  1:40 [PATCH] elf: Restore lconfig " Sam James
2023-02-16  2:23 ` [PATCH v3] elf: Restore ldconfig " Joan Bruguera
2023-02-16  6:08   ` Florian Weimer
2023-02-16  1:24 [PATCH v2] " Joan Bruguera
2023-02-16  2:08 ` [PATCH v3] " Joan Bruguera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230218221915.3938215-1-joanbrugueram@gmail.com \
    --to=joanbrugueram@gmail.com \
    --cc=87wn4iqh17.fsf@oldenburg.str.redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).