public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [hurd,commited] glob64_time64: Fix typo for stub_warning call (BZ #30146)
@ 2023-02-19 22:23 Samuel Thibault
  2023-02-20 11:14 ` [hurd, commited] " Florian Weimer
  0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2023-02-19 22:23 UTC (permalink / raw)
  To: libc-alpha; +Cc: Samuel Thibault, commit-hurd

We were erroneously reporting a stub warning for glob64 instead of
glob64_time64.
---
 posix/glob64-time64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/posix/glob64-time64.c b/posix/glob64-time64.c
index 69f6f02116..196429eb6a 100644
--- a/posix/glob64-time64.c
+++ b/posix/glob64-time64.c
@@ -45,6 +45,6 @@ __glob64_time64 (const char *pattern, int flags,
 }
 libc_hidden_def (__glob64_time64)
 
-stub_warning (glob64)
+stub_warning (glob64_time64)
 
 #endif
-- 
2.39.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [hurd, commited] glob64_time64: Fix typo for stub_warning call (BZ #30146)
  2023-02-19 22:23 [hurd,commited] glob64_time64: Fix typo for stub_warning call (BZ #30146) Samuel Thibault
@ 2023-02-20 11:14 ` Florian Weimer
  2023-02-20 12:45   ` Samuel Thibault
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2023-02-20 11:14 UTC (permalink / raw)
  To: Samuel Thibault; +Cc: libc-alpha, commit-hurd

* Samuel Thibault:

> We were erroneously reporting a stub warning for glob64 instead of
> glob64_time64.
> ---
>  posix/glob64-time64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/posix/glob64-time64.c b/posix/glob64-time64.c
> index 69f6f02116..196429eb6a 100644
> --- a/posix/glob64-time64.c
> +++ b/posix/glob64-time64.c
> @@ -45,6 +45,6 @@ __glob64_time64 (const char *pattern, int flags,
>  }
>  libc_hidden_def (__glob64_time64)
>  
> -stub_warning (glob64)
> +stub_warning (glob64_time64)

Shouldn't this be __glob64_time64?

Thanks,
Florian


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [hurd, commited] glob64_time64: Fix typo for stub_warning call (BZ #30146)
  2023-02-20 11:14 ` [hurd, commited] " Florian Weimer
@ 2023-02-20 12:45   ` Samuel Thibault
  0 siblings, 0 replies; 3+ messages in thread
From: Samuel Thibault @ 2023-02-20 12:45 UTC (permalink / raw)
  To: Florian Weimer; +Cc: libc-alpha, commit-hurd

Florian Weimer, le lun. 20 févr. 2023 12:14:04 +0100, a ecrit:
> * Samuel Thibault:
> 
> > We were erroneously reporting a stub warning for glob64 instead of
> > glob64_time64.
> > ---
> >  posix/glob64-time64.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/posix/glob64-time64.c b/posix/glob64-time64.c
> > index 69f6f02116..196429eb6a 100644
> > --- a/posix/glob64-time64.c
> > +++ b/posix/glob64-time64.c
> > @@ -45,6 +45,6 @@ __glob64_time64 (const char *pattern, int flags,
> >  }
> >  libc_hidden_def (__glob64_time64)
> >  
> > -stub_warning (glob64)
> > +stub_warning (glob64_time64)
> 
> Shouldn't this be __glob64_time64?

Ah, there is no non-__ alias indeed, fixed so.

Thanks,
Samuel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-20 12:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-19 22:23 [hurd,commited] glob64_time64: Fix typo for stub_warning call (BZ #30146) Samuel Thibault
2023-02-20 11:14 ` [hurd, commited] " Florian Weimer
2023-02-20 12:45   ` Samuel Thibault

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).