From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org,
"Flávio Cruz" <flaviocruz@gmail.com>,
"Noah Goldstein" <goldstein.w.n@gmail.com>
Subject: Re: [PATCH v2 1/4] hurd: Simplify init-first.c further
Date: Thu, 23 Feb 2023 00:26:46 +0100 [thread overview]
Message-ID: <20230222232646.sc3l7rec2wpalpxy@begin> (raw)
In-Reply-To: <20230221211932.296459-2-bugaevc@gmail.com>
Hello,
Thanks for this!
Did you try to run make check?
Sergey Bugaev via Libc-alpha, le mer. 22 févr. 2023 00:19:29 +0300, a ecrit:
> This drops all of the return address rewriting kludges. The only
> remaining hack is the jump out of a call stack while adjusting the
> stack pointer.
Is this hack really still needed? Since we don't switch stack any more,
we could as well just return normally?
> --- a/sysdeps/mach/hurd/dl-sysdep.c
> +++ b/sysdeps/mach/hurd/dl-sysdep.c
> @@ -207,6 +207,9 @@ _dl_sysdep_start (void **start_argptr,
> }
> }
>
> + extern void _dl_init_first (void *data);
Please put extern function declaration into a header, dl-sysdep.h for
instance.
> diff --git a/sysdeps/mach/hurd/i386/init-first.c b/sysdeps/mach/hurd/i386/init-first.c
> index a558da16..34e8dcc0 100644
> --- a/sysdeps/mach/hurd/i386/init-first.c
> +++ b/sysdeps/mach/hurd/i386/init-first.c
> + {
> + /* Check if the stack we are now on is different from
> + the one described by _hurd_stack_{base,size}. */
>
> + char dummy;
> + const vm_address_t newsp = (vm_address_t) &dummy;
> +
> + if (d->stack_size != 0 && (newsp < d->stack_base
> + || newsp - d->stack_base > d->stack_size))
> + /* The new stack pointer does not intersect with the
> + stack the exec server set up for us, so free that stack. */
> + __vm_deallocate (__mach_task_self (), d->stack_base, d->stack_size);
> + }
Again, I don't think this is needed any more since we don't switch stack
any more?
Samuel
next prev parent reply other threads:[~2023-02-22 23:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 21:19 [PATCH v2 0/4] More x86_64-gnu glibc work Sergey Bugaev
2023-02-21 21:19 ` [PATCH v2 1/4] hurd: Simplify init-first.c further Sergey Bugaev
2023-02-22 23:26 ` Samuel Thibault [this message]
2023-02-23 13:54 ` Sergey Bugaev
2023-02-23 15:14 ` [PATCH v3 1/2] " Sergey Bugaev
2023-02-23 15:14 ` [PATCH v3 2/2] hurd: Generalize init-first.c to support x86_64 Sergey Bugaev
2023-02-24 1:08 ` [PATCH v2 1/4] hurd: Simplify init-first.c further Samuel Thibault
2023-02-24 19:43 ` Samuel Thibault
2023-02-21 21:19 ` [PATCH v2 2/4] hurd: Generalize init-first.c to support x86_64 Sergey Bugaev
2023-02-21 21:19 ` [PATCH v2 3/4] hurd: Implement TLS for x86_64 Sergey Bugaev
2023-02-27 22:22 ` Samuel Thibault
2023-02-21 21:19 ` [PATCH v2 4/4] htl: Add pthreadtypes-arch.h " Sergey Bugaev
2023-02-27 22:30 ` Samuel Thibault
2023-02-22 23:32 ` [PATCH v2 0/4] More x86_64-gnu glibc work Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222232646.sc3l7rec2wpalpxy@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=flaviocruz@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).