From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org,
"Flávio Cruz" <flaviocruz@gmail.com>,
"Noah Goldstein" <goldstein.w.n@gmail.com>
Subject: Re: [PATCH v2 0/4] More x86_64-gnu glibc work
Date: Thu, 23 Feb 2023 00:32:51 +0100 [thread overview]
Message-ID: <20230222233251.gzcjay3tm275gtgp@begin> (raw)
In-Reply-To: <20230221211932.296459-1-bugaevc@gmail.com>
Sergey Bugaev via Libc-alpha, le mer. 22 févr. 2023 00:19:28 +0300, a ecrit:
> Overall, I think this version is much cleaner.
Definitely :D
> I've tried to write some comments about how _hurd_stack_setup () works. There's
> really not much code to it, but it is tricky, so better have it documented.
Thanks!
> As for x86_64, yes, I have verified that on x86_64-pc-linux-gnu argc/argv/env
> arrive on-stack just like the code in _hurd_stack_setup () expects them to.
Ok, good :)
> I still don't understand why __LIBC_NO_TLS () is supposed to return 0 when we
> have the early TLS configured, but this seems to be what the i386 version does.
I don't remember the details, but most probably that's because there is
more to TLS than the mere early TLS. The gcc accesses are constants from
gs/fs so early TLS is enough. But e.g. _hurd_critical_section_lock would
try to access the sigstate, which will be in the eventual tcbhead, and
not in the early tcbhead.
> Note: this (TLS) still depends on the gnumach patch adding
> i386_fsgs_base_state. If the API is alright, can we push it without an
> implementation, so that userland code (glibc) can be built against it?
We can probably do that, yes.
Samuel
prev parent reply other threads:[~2023-02-22 23:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 21:19 Sergey Bugaev
2023-02-21 21:19 ` [PATCH v2 1/4] hurd: Simplify init-first.c further Sergey Bugaev
2023-02-22 23:26 ` Samuel Thibault
2023-02-23 13:54 ` Sergey Bugaev
2023-02-23 15:14 ` [PATCH v3 1/2] " Sergey Bugaev
2023-02-23 15:14 ` [PATCH v3 2/2] hurd: Generalize init-first.c to support x86_64 Sergey Bugaev
2023-02-24 1:08 ` [PATCH v2 1/4] hurd: Simplify init-first.c further Samuel Thibault
2023-02-24 19:43 ` Samuel Thibault
2023-02-21 21:19 ` [PATCH v2 2/4] hurd: Generalize init-first.c to support x86_64 Sergey Bugaev
2023-02-21 21:19 ` [PATCH v2 3/4] hurd: Implement TLS for x86_64 Sergey Bugaev
2023-02-27 22:22 ` Samuel Thibault
2023-02-21 21:19 ` [PATCH v2 4/4] htl: Add pthreadtypes-arch.h " Sergey Bugaev
2023-02-27 22:30 ` Samuel Thibault
2023-02-22 23:32 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222233251.gzcjay3tm275gtgp@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=flaviocruz@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).