From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org
Subject: Re: [PATCH 2/5] hurd: Microoptimize sigreturn
Date: Tue, 18 Apr 2023 01:23:53 +0200 [thread overview]
Message-ID: <20230417232353.5w4fhwtgimjjif7r@begin> (raw)
In-Reply-To: <20230414193700.542116-2-bugaevc@gmail.com>
Hello,
Sergey Bugaev, le ven. 14 avril 2023 22:36:57 +0300, a ecrit:
> - struct hurd_sigstate *ss = _hurd_self_sigstate ();
> + struct hurd_sigstate *ss;
> +
> + /* We know the sigstate must be initialized,
That doesn't seem to be true, we get segfaults with this patch applied
in these tests:
./htl/tst-kill6.test-result:FAIL: htl/tst-kill6
./htl/tst-pt-tls2.test-result:FAIL: htl/tst-pt-tls2
#0 0x0105a7c2 in sigstate_is_global_rcv (ss=0x0) at hurdsig.c:183
183 && (ss->actions[0].sa_handler == SIG_IGN);
(gdb) bt
#0 0x0105a7c2 in sigstate_is_global_rcv (ss=0x0) at hurdsig.c:183
#1 __GI__hurd_sigstate_lock (ss=0x0) at hurdsig.c:192
#2 0x0108bb17 in __sigreturn (scp=0x2104bec) at ../sysdeps/mach/hurd/i386/sigreturn.c:94
#3 0x010602f6 in trampoline () from ./libc.so.0.3
Samuel
next prev parent reply other threads:[~2023-04-17 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 19:36 [PATCH 1/5] hurd: Fix restoring reply port in sigreturn Sergey Bugaev
2023-04-14 19:36 ` [PATCH 2/5] hurd: Microoptimize sigreturn Sergey Bugaev
2023-04-17 23:23 ` Samuel Thibault [this message]
2023-04-18 9:34 ` Sergey Bugaev
2023-04-18 10:21 ` [PATCH 2/5] hurd: Microoptimize sigreturn Sergey Bugaev
2023-04-18 14:21 ` Samuel Thibault
2023-04-14 19:36 ` [PATCH 3/5] hurd: Implement sigreturn for x86_64 Sergey Bugaev
2023-04-14 19:36 ` [PATCH 4/5] hurd: Simplify _S_catch_exception_raise Sergey Bugaev
2023-04-17 23:24 ` Samuel Thibault
2023-04-14 19:37 ` [PATCH 5/5] hurd: Avoid leaking task & thread ports Sergey Bugaev
2023-04-17 23:24 ` Samuel Thibault
2023-04-17 19:00 ` [PATCH 1/5] hurd: Fix restoring reply port in sigreturn Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417232353.5w4fhwtgimjjif7r@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).