From: Joe Simmons-Talbott <josimmon@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v7 0/4] string: Add tests for strdup and strndup (BZ #30266)
Date: Fri, 21 Apr 2023 10:43:01 -0400 [thread overview]
Message-ID: <20230421144301.GI2106608@oak> (raw)
In-Reply-To: <5ae7c5e1-c02c-17d7-3b78-f8a2767e93ab@linaro.org>
On Fri, Apr 21, 2023 at 11:07:54AM -0300, Adhemerval Zanella Netto wrote:
>
>
> On 21/04/23 10:24, Joe Simmons-Talbott via Libc-alpha wrote:
> > Copy strcpy and strncpy tests to strdup and strndup repectively. Remove
> > tests that checked the surrounding bytes of the result as they are not needed.
>
> Hi Joe,
>
> I appreciate you are working on this and I am aware you are a new
> contributor. However, the way this thread is being unrolled is becoming
> confusing and time consuming. So some tips:
Hi Adhemerval,
Thank you for your thoughful reviews and feedback. I'm sorry for making
this harder on you than needed.
>
> - Please use a proper tool to send patches. For more than one patch,
> just use git send-email (as suggested by 'Contribution Checklist' [1])
> with --cover-letter and --annotate options (so you can double-check if
> something is off with the patches). This avoid messing with
> 'in-reply-to', as you seems to have done in v7.
I'm currently using 'git format-patch' to generate the patches and 'git
send-email' to send them. I only pass '--cover-letter' to format-patch
and did indeed use --in-reply-to for subsequent versions. I'll stop
doing that.
>
> - Avoid replying to an old thread with a new version. It leads to some
> confusion depending of the email reader on how to organize the reply.
Thanks for this tip. I'll stop doing that.
>
> - Always rebase and check the patchset against master. Both you v6 and
> v7 do not fully apply [2] due a recent wcsmbs/Makefile change from
> Florian.
Sorry, I'll make sure to do this in the future.
>
> - Also, always address all the comments before send a new version.
> For instance, you forgot some remarks on my v5 review [3].
I neglected to 'git add' my changes before doing 'git commit --amend'
for v6 which was the reason for my v7.
>
> I have fixed both last two bullet points on a personal branch [4], just
> to avoid dragging this thread with another version. If you are ok with
> this I can install it.
I'm okay with this. Thank you again for all of your help on this
patchset.
Thanks,
Joe
>
> [1] https://sourceware.org/glibc/wiki/Contribution%20checklist
> [2] https://patchwork.sourceware.org/project/glibc/patch/20230421132425.2178020-5-josimmon@redhat.com/
> [3] https://sourceware.org/pipermail/libc-alpha/2023-April/147474.html
> [4] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/bz30266
>
prev parent reply other threads:[~2023-04-21 14:43 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 15:04 [PATCH 0/2] " Joe Simmons-Talbott
2023-03-29 15:04 ` [PATCH 1/2] strdup: Add tests " Joe Simmons-Talbott
2023-03-30 11:16 ` Adhemerval Zanella Netto
2023-03-29 15:05 ` [PATCH 2/2] strndup: " Joe Simmons-Talbott
2023-03-30 11:19 ` Adhemerval Zanella Netto
2023-03-30 14:50 ` [PATCH v2 0/2] Add tests for strdup and strndup " Joe Simmons-Talbott
2023-03-30 14:50 ` [PATCH v2 1/2] strdup: Add tests " Joe Simmons-Talbott
2023-04-04 13:44 ` Adhemerval Zanella Netto
2023-03-30 14:50 ` [PATCH v2 2/2] strndup: " Joe Simmons-Talbott
2023-04-04 19:00 ` [PATCH v3 0/3] string: Add tests for strdup and strndup " Joe Simmons-Talbott
2023-04-04 19:00 ` [PATCH v3 1/3] string: Allow use of test-string.h for non-ifunc implementations Joe Simmons-Talbott
2023-04-07 18:19 ` Adhemerval Zanella Netto
2023-04-04 19:00 ` [PATCH v3 2/3] string: Add tests for strdup (BZ #30266) Joe Simmons-Talbott
2023-04-04 19:17 ` Noah Goldstein
2023-04-04 19:40 ` Adhemerval Zanella Netto
2023-04-07 18:19 ` Adhemerval Zanella Netto
2023-04-10 13:53 ` Joe Simmons-Talbott
2023-04-10 14:44 ` Adhemerval Zanella Netto
2023-04-04 19:00 ` [PATCH v3 3/3] string: Add tests for strndup " Joe Simmons-Talbott
2023-04-07 18:19 ` Adhemerval Zanella Netto
2023-04-10 15:59 ` [PATCH v4 0/4] string: Add tests for strdup and " Joe Simmons-Talbott
2023-04-10 15:59 ` [PATCH v4 1/4] string: Allow use of test-string.h for non-ifunc implementations Joe Simmons-Talbott
2023-04-10 15:59 ` [PATCH v4 2/4] string: Add tests for strdup (BZ #30266) Joe Simmons-Talbott
2023-04-11 16:57 ` Adhemerval Zanella Netto
2023-04-10 15:59 ` [PATCH v4 3/4] string: Add tests for strndup " Joe Simmons-Talbott
2023-04-11 17:29 ` Adhemerval Zanella Netto
2023-04-10 15:59 ` [PATCH v4 4/4] wcsmbs: Add wcsdup() tests. " Joe Simmons-Talbott
2023-04-11 17:30 ` Adhemerval Zanella Netto
2023-04-11 19:05 ` [PATCH v5 0/4] string: Add tests for strdup and strndup " Joe Simmons-Talbott
2023-04-11 19:05 ` [PATCH v5 1/4] string: Allow use of test-string.h for non-ifunc implementations Joe Simmons-Talbott
2023-04-11 19:05 ` [PATCH v5 2/4] string: Add tests for strdup (BZ #30266) Joe Simmons-Talbott
2023-04-20 15:51 ` Adhemerval Zanella Netto
2023-04-11 19:05 ` [PATCH v5 3/4] string: Add tests for strndup " Joe Simmons-Talbott
2023-04-20 15:51 ` Adhemerval Zanella Netto
2023-04-11 19:05 ` [PATCH v5 4/4] wcsmbs: Add wcsdup() tests. " Joe Simmons-Talbott
2023-04-19 14:24 ` [PATCH v5 0/4] string: Add tests for strdup and strndup " Joe Simmons-Talbott
2023-04-20 16:54 ` [PATCH v6 " Joe Simmons-Talbott
2023-04-20 16:54 ` [PATCH v6 1/4] string: Allow use of test-string.h for non-ifunc implementations Joe Simmons-Talbott
2023-04-20 16:54 ` [PATCH v6 2/4] string: Add tests for strdup (BZ #30266) Joe Simmons-Talbott
2023-04-20 16:54 ` [PATCH v6 3/4] string: Add tests for strndup " Joe Simmons-Talbott
2023-04-20 16:54 ` [PATCH v6 4/4] wcsmbs: Add wcsdup() tests. " Joe Simmons-Talbott
2023-04-21 13:24 ` [PATCH v7 0/4] string: Add tests for strdup and strndup " Joe Simmons-Talbott
2023-04-21 13:24 ` [PATCH v7 1/4] string: Allow use of test-string.h for non-ifunc implementations Joe Simmons-Talbott
2023-04-21 13:24 ` [PATCH v7 2/4] string: Add tests for strdup (BZ #30266) Joe Simmons-Talbott
2023-04-21 13:24 ` [PATCH v7 3/4] string: Add tests for strndup " Joe Simmons-Talbott
2023-04-21 13:24 ` [PATCH v7 4/4] wcsmbs: Add wcsdup() tests. " Joe Simmons-Talbott
2023-04-21 14:07 ` [PATCH v7 0/4] string: Add tests for strdup and strndup " Adhemerval Zanella Netto
2023-04-21 14:43 ` Joe Simmons-Talbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421144301.GI2106608@oak \
--to=josimmon@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).