Re: [PATCH v7 0/4] string: Add tests for strdup and strndup (BZ #30266)

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 21/04/23 10:24, Joe Simmons-Talbott via Libc-alpha wrote:
> Copy strcpy and strncpy tests to strdup and strndup repectively.  Remove
> tests that checked the surrounding bytes of the result as they are not needed.

Hi Joe,

I appreciate you are working on this and I am aware you are a new 
contributor. However, the way this thread is being unrolled is becoming 
confusing and time consuming.  So some tips:

  - Please use a proper tool to send patches.  For more than one patch, 
    just use git send-email (as suggested by 'Contribution Checklist' [1])
    with --cover-letter and --annotate options (so you can double-check if
    something is off with the patches).  This avoid messing with 
    'in-reply-to', as you seems to have done in v7.

  - Avoid replying to an old thread with a new version.  It leads to some
    confusion depending of the email reader on how to organize the reply.

  - Always rebase and check the patchset against master. Both you v6 and
    v7 do not fully apply [2] due a recent wcsmbs/Makefile change from
    Florian.

  - Also, always address all the comments before send a new version.  
    For instance, you forgot some remarks on my v5 review [3].
    
I have fixed both last two bullet points on a personal branch [4], just
to avoid dragging this thread with another version. If you are ok with
this I can install it.

[1] https://sourceware.org/glibc/wiki/Contribution%20checklist
[2] https://patchwork.sourceware.org/project/glibc/patch/20230421132425.2178020-5-josimmon@redhat.com/
[3] https://sourceware.org/pipermail/libc-alpha/2023-April/147474.html
[4] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/bz30266