From: Joe Simmons-Talbott <josimmon@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] vfprintf-internal: Replace alloca with malloc.
Date: Wed, 17 May 2023 15:41:56 -0400 [thread overview]
Message-ID: <20230517194156.GH176347@oak> (raw)
In-Reply-To: <8e9beea2-b128-83f1-dead-2c3866e28182@cs.ucla.edu>
On Wed, May 17, 2023 at 11:08:39AM -0700, Paul Eggert wrote:
> On 2023-05-15 11:50, Joe Simmons-Talbott via Libc-alpha wrote:
> > + args_value[cnt].pa_user = malloc (args_size[cnt]);
> > + if (args_value[cnt].pa_user == NULL)
> > + break;
>
> Shouldn't an error be returned if a printf function runs out of memory
> internally?
I'll fix this in the next version. Thanks.
>
> Also, that function already uses a scratch buffer; why not grow the scratch
> buffer instead of calling malloc separately?
>
It seems to me that the code to grow the scratch buffer would be more
difficult to understand than calling malloc separately. Perhaps I'm just
intimidated by the pointer math.
Thanks,
Joe
next prev parent reply other threads:[~2023-05-17 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 18:50 Joe Simmons-Talbott
2023-05-17 18:08 ` Paul Eggert
2023-05-17 18:53 ` Cristian Rodríguez
2023-05-17 19:41 ` Joe Simmons-Talbott [this message]
2023-05-17 20:07 ` Paul Eggert
2023-05-17 21:32 ` Joe Simmons-Talbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517194156.GH176347@oak \
--to=josimmon@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).