From: Joe Simmons-Talbott <josimmon@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] vfprintf-internal: Replace alloca with malloc.
Date: Wed, 17 May 2023 17:32:28 -0400 [thread overview]
Message-ID: <20230517213228.GI176347@oak> (raw)
In-Reply-To: <8ddf10d7-e084-6530-c143-f1691870e863@cs.ucla.edu>
On Wed, May 17, 2023 at 01:07:58PM -0700, Paul Eggert wrote:
> On 2023-05-17 12:41, Joe Simmons-Talbott wrote:
> > It seems to me that the code to grow the scratch buffer would be more
> > difficult to understand than calling malloc separately.
>
> True, but in the normal case this means malloc will not be called (as the
> data will live in a small scratch buffer on the stack), and that's a win
> worth striving for.
>
I've posted a new patch with my attempt at reusing the scratch_buffer.
[1]
Thanks,
Joe
[1] https://sourceware.org/pipermail/libc-alpha/2023-May/148232.html
prev parent reply other threads:[~2023-05-17 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 18:50 Joe Simmons-Talbott
2023-05-17 18:08 ` Paul Eggert
2023-05-17 18:53 ` Cristian Rodríguez
2023-05-17 19:41 ` Joe Simmons-Talbott
2023-05-17 20:07 ` Paul Eggert
2023-05-17 21:32 ` Joe Simmons-Talbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517213228.GI176347@oak \
--to=josimmon@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).