From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org
Subject: Re: [PATCH 07/10] hurd: Fix x86_64 _hurd_tls_fork
Date: Wed, 17 May 2023 23:01:10 +0200 [thread overview]
Message-ID: <20230517210110.o3rfm6ftpjkhi3el@begin> (raw)
In-Reply-To: <20230517191436.73636-8-bugaevc@gmail.com>
Applied, thanks!
Sergey Bugaev via Libc-alpha, le mer. 17 mai 2023 22:14:33 +0300, a ecrit:
> It is illegal to call thread_get_state () on mach_thread_self (), so
> this codepath cannot be used as-is to fork the calling thread's TLS.
> Fortunately we can use THREAD_SELF (aka %fs:0x0) to find out the value
> of our fs_base without calling into the kernel.
>
> Fixes: f6cf701efc61c9ad910372bda14b9a235db310a8
> "hurd: Implement TLS for x86_64"
>
> Checked on x86_64-gnu: fork () now works!
>
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
> It would be nice if GNU Mach allowed
>
> thread_get_state (mach_thread_self (), i386_FSGS_BASE_STATE)
>
> like it already allows thread_set_state for this case. But even if
> gnumach adds suppport for this, doing it in userspace without an extra
> RPC is still better.
>
> sysdeps/mach/hurd/x86_64/tls.h | 25 +++++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/sysdeps/mach/hurd/x86_64/tls.h b/sysdeps/mach/hurd/x86_64/tls.h
> index 35dcef44..6487ed35 100644
> --- a/sysdeps/mach/hurd/x86_64/tls.h
> +++ b/sysdeps/mach/hurd/x86_64/tls.h
> @@ -140,12 +140,25 @@ _hurd_tls_fork (thread_t child, thread_t orig,
> error_t err;
> struct i386_fsgs_base_state state;
> mach_msg_type_number_t state_count = i386_FSGS_BASE_STATE_COUNT;
> - err = __thread_get_state (orig, i386_FSGS_BASE_STATE,
> - (thread_state_t) &state,
> - &state_count);
> - if (err)
> - return err;
> - assert (state_count == i386_FSGS_BASE_STATE_COUNT);
> +
> + extern thread_t hurd_thread_self (void);
> + if (orig != hurd_thread_self ())
> + {
> + err = __thread_get_state (orig, i386_FSGS_BASE_STATE,
> + (thread_state_t) &state,
> + &state_count);
> + if (err)
> + return err;
> + assert (state_count == i386_FSGS_BASE_STATE_COUNT);
> + }
> + else
> + {
> + /* It is illegal to call thread_get_state () on mach_thread_self ().
> + But we're only interested in the value of fs_base, and since we're
> + this thread, we know it points to our TCB. */
> + state.fs_base = (unsigned long) THREAD_SELF;
> + state.gs_base = 0;
> + }
>
> return __thread_set_state (child, i386_FSGS_BASE_STATE,
> (thread_state_t) &state,
> --
> 2.40.1
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
next prev parent reply other threads:[~2023-05-17 21:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 19:14 [PATCH 00/10] Stack setup & misc fixes for x86_64-gnu Sergey Bugaev
2023-05-17 19:14 ` [PATCH 01/10] Remove sysdeps/generic/thread_state.h Sergey Bugaev
2023-05-17 20:50 ` Samuel Thibault
2023-05-17 19:14 ` [PATCH 02/10] mach: Define MACHINE_THREAD_STATE_SETUP_CALL Sergey Bugaev
2023-05-17 20:52 ` Samuel Thibault
2023-05-17 19:14 ` [PATCH 03/10] hurd: Use MACHINE_THREAD_STATE_SETUP_CALL Sergey Bugaev
2023-05-17 20:52 ` [PATCH 03/10] hurd: Use MACHINE_THREAD_STATE_SETUP_CALLo Samuel Thibault
2023-05-17 19:14 ` [PATCH 04/10] mach: Add __mach_setup_thread_call () Sergey Bugaev
2023-05-17 20:56 ` Samuel Thibault
2023-05-17 19:14 ` [PATCH 05/10] hurd: Use " Sergey Bugaev
2023-05-17 20:57 ` Samuel Thibault
2023-05-17 19:14 ` [RFC PATCH 06/10] hurd: Make sure to not use tcb->self Sergey Bugaev
2023-05-17 20:59 ` Samuel Thibault
2023-05-18 18:55 ` Joseph Myers
2023-05-18 19:33 ` Sergey Bugaev
2023-05-18 20:16 ` Joseph Myers
2023-05-18 23:47 ` Samuel Thibault
2023-05-19 8:22 ` Sergey Bugaev
2023-05-19 9:39 ` Florian Weimer
2023-05-19 16:50 ` Joseph Myers
2023-05-19 14:47 ` [PATCH] hurd: Fix using interposable hurd_thread_self Sergey Bugaev
2023-05-19 18:57 ` Samuel Thibault
2023-05-17 19:14 ` [PATCH 07/10] hurd: Fix x86_64 _hurd_tls_fork Sergey Bugaev
2023-05-17 21:01 ` Samuel Thibault [this message]
2023-05-17 19:14 ` [PATCH 08/10] hurd: Fix setting up pthreads Sergey Bugaev
2023-05-17 21:02 ` Samuel Thibault
2023-05-17 19:14 ` [PATCH 09/10] hurd: Also make it possible to call strlen very early Sergey Bugaev
2023-05-17 21:04 ` Samuel Thibault
2023-05-17 19:14 ` [RFC PATCH 10/10] hurd: Regenerate errno.h Sergey Bugaev
2023-05-17 19:39 ` Joseph Myers
2023-05-17 21:04 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517210110.o3rfm6ftpjkhi3el@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).