[PATCH glibc] Fix build for hurd/thread-self.c for i386.

[PATCH glibc] Fix build for hurd/thread-self.c for i386.

[Flavio Cruz]

We need to include hurd.h for libc_hidden_proto (__hurd_thread_self),
introduced in https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=b44c1e12524bb5de0f93294a7c24c8e41c06bb75

This the error log:

In file included from <command-line>:
./../include/libc-symbols.h:472:33: error: '__EI___hurd_thread_self' aliased to undefined symbol '__GI___hurd_thread_self'
  472 |   extern thread __typeof (name) __EI_##name \
      |                                 ^~~~~
./../include/libc-symbols.h:468:3: note: in expansion of macro '__hidden_ver2'
  468 |   __hidden_ver2 (, local, internal, name)
      |   ^~~~~~~~~~~~~
./../include/libc-symbols.h:476:41: note: in expansion of macro '__hidden_ver1'
  476 | #  define hidden_def(name)              __hidden_ver1(__GI_##name, name, name);
      |                                         ^~~~~~~~~~~~~
./../include/libc-symbols.h:557:32: note: in expansion of macro 'hidden_def'
  557 | # define libc_hidden_def(name) hidden_def (name)
      |                                ^~~~~~~~~~
thread-self.c:27:1: note: in expansion of macro 'libc_hidden_def'
   27 | libc_hidden_def (__hurd_thread_self)
      | ^~~~~~~~~~~~~~~
---
 hurd/thread-self.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hurd/thread-self.c b/hurd/thread-self.c
index af013503bf..494a127aa5 100644
--- a/hurd/thread-self.c
+++ b/hurd/thread-self.c
@@ -16,6 +16,7 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
+#include <hurd.h>
 #include <hurd/signal.h>
 
 thread_t
-- 
2.39.2

Re: [PATCH glibc] Fix build for hurd/thread-self.c for i386.

[Samuel Thibault]

Applied, thanks!

Flavio Cruz, le lun. 22 mai 2023 01:16:50 -0400, a ecrit:
> We need to include hurd.h for libc_hidden_proto (__hurd_thread_self),
> introduced in https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=b44c1e12524bb5de0f93294a7c24c8e41c06bb75
> 
> This the error log:
> 
> In file included from <command-line>:
> ./../include/libc-symbols.h:472:33: error: '__EI___hurd_thread_self' aliased to undefined symbol '__GI___hurd_thread_self'
>   472 |   extern thread __typeof (name) __EI_##name \
>       |                                 ^~~~~
> ./../include/libc-symbols.h:468:3: note: in expansion of macro '__hidden_ver2'
>   468 |   __hidden_ver2 (, local, internal, name)
>       |   ^~~~~~~~~~~~~
> ./../include/libc-symbols.h:476:41: note: in expansion of macro '__hidden_ver1'
>   476 | #  define hidden_def(name)              __hidden_ver1(__GI_##name, name, name);
>       |                                         ^~~~~~~~~~~~~
> ./../include/libc-symbols.h:557:32: note: in expansion of macro 'hidden_def'
>   557 | # define libc_hidden_def(name) hidden_def (name)
>       |                                ^~~~~~~~~~
> thread-self.c:27:1: note: in expansion of macro 'libc_hidden_def'
>    27 | libc_hidden_def (__hurd_thread_self)
>       | ^~~~~~~~~~~~~~~
> ---
>  hurd/thread-self.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hurd/thread-self.c b/hurd/thread-self.c
> index af013503bf..494a127aa5 100644
> --- a/hurd/thread-self.c
> +++ b/hurd/thread-self.c
> @@ -16,6 +16,7 @@
>     License along with the GNU C Library; if not, see
>     <https://www.gnu.org/licenses/>.  */
>  
> +#include <hurd.h>
>  #include <hurd/signal.h>
>  
>  thread_t
> -- 
> 2.39.2
>