* [hurd,commited] mach: Fix mach_setup_thread_impl with NULL stack_base
@ 2023-05-22 18:05 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2023-05-22 18:05 UTC (permalink / raw)
To: libc-alpha; +Cc: Samuel Thibault, commit-hurd
This is notably necessary for running the gmon thread.
---
mach/setup-thread.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mach/setup-thread.c b/mach/setup-thread.c
index 0e149787f8..af16d6cb84 100644
--- a/mach/setup-thread.c
+++ b/mach/setup-thread.c
@@ -33,7 +33,7 @@ mach_setup_thread_impl (task_t task, thread_t thread, int is_call,
kern_return_t error;
struct machine_thread_state ts;
mach_msg_type_number_t tssize = MACHINE_THREAD_STATE_COUNT;
- vm_address_t stack;
+ vm_address_t stack, stack_start;
vm_size_t size;
int anywhere;
@@ -51,22 +51,22 @@ mach_setup_thread_impl (task_t task, thread_t thread, int is_call,
*stack_size = size;
#ifdef STACK_GROWTH_DOWN
- if (stack_base)
- *stack_base = stack + __vm_page_size;
+ stack_start = stack + __vm_page_size;
#elif defined (STACK_GROWTH_UP)
- if (stack_base)
- *stack_base = stack;
+ stack_start = stack;
stack += size;
#else
#error stack direction unknown
#endif
+ if (stack_base)
+ *stack_base = stack_start;
if (is_call)
- MACHINE_THREAD_STATE_SETUP_CALL (&ts, *stack_base, size, pc);
+ MACHINE_THREAD_STATE_SETUP_CALL (&ts, stack_start, size, pc);
else
{
MACHINE_THREAD_STATE_SET_PC (&ts, pc);
- MACHINE_THREAD_STATE_SET_SP (&ts, *stack_base, size);
+ MACHINE_THREAD_STATE_SET_SP (&ts, stack_start, size);
}
/* Create the red zone. */
--
2.39.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-05-22 18:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 18:05 [hurd,commited] mach: Fix mach_setup_thread_impl with NULL stack_base Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).