* [PATCH v2] io: Fix record locking contants on 32 bit arch with 64 bit default time_t (BZ#30477)
@ 2023-05-25 13:51 Adhemerval Zanella
2023-05-30 11:19 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella @ 2023-05-25 13:51 UTC (permalink / raw)
To: libc-alpha, Bo YU
For architecture with default 64 bit time_t support, the kernel
does not provide LFS and non-LFS values for F_GETLK, F_GETLK, and
F_GETLK (the default value used for 64 bit architecture are used).
This is might be considered an ABI break, but the currenct exported
values is bogus anyway.
The POSIX lockf is not affected since it is aliased to lockf64,
which already uses the LFS values.
Checked on i686-linux-gnu and the new tests on a riscv32.
---
Changes from v1:
* Remove parens on defined operator.
* Make the test use tst-flock skeleton.
---
io/Makefile | 1 +
io/tst-fcntl-lock.c | 97 ++++++++++++++++++++++
io/tst-lockf.c | 58 +++++++------
sysdeps/unix/sysv/linux/bits/fcntl-linux.h | 2 +-
4 files changed, 133 insertions(+), 25 deletions(-)
create mode 100644 io/tst-fcntl-lock.c
diff --git a/io/Makefile b/io/Makefile
index db886ca26f..d573064ecc 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -175,6 +175,7 @@ tests := \
tst-fchmodat \
tst-fchownat \
tst-fcntl \
+ tst-fcntl-lock \
tst-fstatat \
tst-fts \
tst-fts-lfs \
diff --git a/io/tst-fcntl-lock.c b/io/tst-fcntl-lock.c
new file mode 100644
index 0000000000..357c4b7b56
--- /dev/null
+++ b/io/tst-fcntl-lock.c
@@ -0,0 +1,97 @@
+/* Test for advisory record locking.
+ Copyright (C) 2023 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public License
+ as published by the Free Software Foundation; either version 2
+ of the License, or (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, see <https://www.gnu.org/licenses/>.
+*/
+
+#include <fcntl.h>
+#include <errno.h>
+#include <unistd.h>
+
+/* This is essentially the POSIX lockf. */
+
+static int
+fcntl_lockf (int fd, int cmd, off_t len)
+{
+ struct flock fl = {
+ .l_type = F_WRLCK,
+ .l_whence = SEEK_CUR,
+ .l_len = len
+ };
+
+ switch (cmd)
+ {
+ case F_TEST:
+ fl.l_type = F_RDLCK;
+ if (fcntl (fd, F_GETLK, &fl) < 0)
+ return -1;
+ if (fl.l_type == F_UNLCK || fl.l_pid == getpid ())
+ return 0;
+ errno = EACCES;
+ return -1;
+
+ case F_ULOCK:
+ fl.l_type = F_UNLCK;
+ return fcntl (fd, F_SETLK, &fl);
+
+ case F_LOCK:
+ return fcntl (fd, F_SETLKW, &fl);
+
+ case F_TLOCK:
+ return fcntl (fd, F_SETLK, &fl);
+ }
+
+ errno = EINVAL;
+ return -1;
+}
+
+static int
+fcntl64_lockf (int fd, int cmd, off64_t len64)
+ {
+ struct flock64 fl64 = {
+ .l_type = F_WRLCK,
+ .l_whence = SEEK_CUR,
+ .l_len = len64
+ };
+
+ switch (cmd)
+ {
+ case F_TEST:
+ fl64.l_type = F_RDLCK;
+ if (fcntl64 (fd, F_GETLK64, &fl64) < 0)
+ return -1;
+ if (fl64.l_type == F_UNLCK || fl64.l_pid == getpid ())
+ return 0;
+ errno = EACCES;
+ return -1;
+
+ case F_ULOCK:
+ fl64.l_type = F_UNLCK;
+ return fcntl64 (fd, F_SETLK64, &fl64);
+
+ case F_LOCK:
+ return fcntl64 (fd, F_SETLKW64, &fl64);
+
+ case F_TLOCK:
+ return fcntl64 (fd, F_SETLK64, &fl64);
+ }
+
+ errno = EINVAL;
+ return -1;
+}
+
+#define TST_LOCKFD "tst-fcntl-lock."
+#define LOCKF fcntl_lockf
+#define LOCKF64 fcntl64_lockf
+#include "tst-lockf.c"
diff --git a/io/tst-lockf.c b/io/tst-lockf.c
index eda04b5417..cf8d3001c3 100644
--- a/io/tst-lockf.c
+++ b/io/tst-lockf.c
@@ -24,13 +24,23 @@
#include <support/capture_subprocess.h>
#include <support/check.h>
+#ifndef TST_LOCKFD
+# define TST_LOCKFD "tst-lockfd."
+#endif
+#ifndef LOCKF
+# define LOCKF lockf
+#endif
+#ifndef LOCKF64
+# define LOCKF64 lockf64
+#endif
+
static char *temp_filename;
static int temp_fd;
static void
do_prepare (int argc, char **argv)
{
- temp_fd = create_temp_file ("tst-lockfd.", &temp_filename);
+ temp_fd = create_temp_file (TST_LOCKFD, &temp_filename);
TEST_VERIFY_EXIT (temp_fd != -1);
}
#define PREPARE do_prepare
@@ -40,22 +50,22 @@ do_test_child_lockf (void *closure)
{
/* Check if parent has [0, 1024) locked. */
TEST_COMPARE (lseek (temp_fd, 0, SEEK_SET), 0);
- TEST_COMPARE (lockf (temp_fd, F_TLOCK, 1024), -1);
+ TEST_COMPARE (LOCKF (temp_fd, F_TLOCK, 1024), -1);
TEST_COMPARE (errno, EAGAIN);
- TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), -1);
+ TEST_COMPARE (LOCKF (temp_fd, F_TEST, 1024), -1);
TEST_COMPARE (errno, EACCES);
/* Also Check if parent has last 1024 bytes locked. */
TEST_COMPARE (lseek (temp_fd, INT32_MAX-1024, SEEK_SET), INT32_MAX-1024);
- TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), -1);
+ TEST_COMPARE (LOCKF (temp_fd, F_TEST, 1024), -1);
/* And try to lock [1024, 2048). */
TEST_COMPARE (lseek (temp_fd, 1024, SEEK_SET), 1024);
- TEST_COMPARE (lockf (temp_fd, F_LOCK, 1024), 0);
+ TEST_COMPARE (LOCKF (temp_fd, F_LOCK, 1024), 0);
/* Check if non-LFS interface cap access to 32-bif off_t. */
TEST_COMPARE (lseek64 (temp_fd, (off64_t)INT32_MAX, SEEK_SET),
(off64_t)INT32_MAX);
- TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), 0);
}
static void
@@ -63,32 +73,32 @@ do_test_child_lockf64 (void *closure)
{
/* Check if parent has [0, 1024) locked. */
TEST_COMPARE (lseek64 (temp_fd, 0, SEEK_SET), 0);
- TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), -1);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TLOCK, 1024), -1);
TEST_COMPARE (errno, EAGAIN);
- TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), -1);
TEST_COMPARE (errno, EACCES);
/* Also Check if parent has last 1024 bytes locked. */
TEST_COMPARE (lseek64 (temp_fd, INT32_MAX-1024, SEEK_SET), INT32_MAX-1024);
- TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), -1);
/* And try to lock [1024, 2048). */
TEST_COMPARE (lseek64 (temp_fd, 1024, SEEK_SET), 1024);
- TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
/* And also [INT32_MAX, INT32_MAX+1024). */
{
off64_t off = (off64_t)INT32_MAX;
TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
- TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
}
/* Check if [INT32_MAX+1024, INT64_MAX) is locked. */
{
off64_t off = (off64_t)INT32_MAX+1024;
TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
- TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), -1);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TLOCK, 1024), -1);
TEST_COMPARE (errno, EAGAIN);
- TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), -1);
TEST_COMPARE (errno, EACCES);
}
}
@@ -97,38 +107,38 @@ static int
do_test (void)
{
/* Basic tests to check if a lock can be obtained and checked. */
- TEST_COMPARE (lockf (temp_fd, F_LOCK, 1024), 0);
- TEST_COMPARE (lockf (temp_fd, F_LOCK, INT32_MAX), 0);
- TEST_COMPARE (lockf (temp_fd, F_TLOCK, 1024), 0);
- TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), 0);
+ TEST_COMPARE (LOCKF (temp_fd, F_LOCK, 1024), 0);
+ TEST_COMPARE (LOCKF (temp_fd, F_LOCK, INT32_MAX), 0);
+ TEST_COMPARE (LOCKF (temp_fd, F_TLOCK, 1024), 0);
+ TEST_COMPARE (LOCKF (temp_fd, F_TEST, 1024), 0);
TEST_COMPARE (lseek (temp_fd, 1024, SEEK_SET), 1024);
- TEST_COMPARE (lockf (temp_fd, F_ULOCK, 1024), 0);
+ TEST_COMPARE (LOCKF (temp_fd, F_ULOCK, 1024), 0);
/* Parent process should have ([0, 1024), [2048, INT32_MAX)) ranges locked. */
{
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child_lockf, NULL);
- support_capture_subprocess_check (&result, "lockf", 0, sc_allow_none);
+ support_capture_subprocess_check (&result, "LOCKF", 0, sc_allow_none);
}
if (sizeof (off_t) != sizeof (off64_t))
{
/* Check if previously locked regions with LFS symbol. */
TEST_COMPARE (lseek (temp_fd, 0, SEEK_SET), 0);
- TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
- TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), 0);
- TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TLOCK, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), 0);
/* Lock region [INT32_MAX+1024, INT64_MAX). */
off64_t off = (off64_t)INT32_MAX + 1024;
TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
- TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
+ TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
/* Parent process should have ([0, 1024), [2048, INT32_MAX),
[INT32_MAX+1024, INT64_MAX)) ranges locked. */
{
struct support_capture_subprocess result;
result = support_capture_subprocess (do_test_child_lockf64, NULL);
- support_capture_subprocess_check (&result, "lockf", 0, sc_allow_none);
+ support_capture_subprocess_check (&result, "LOCKF", 0, sc_allow_none);
}
}
diff --git a/sysdeps/unix/sysv/linux/bits/fcntl-linux.h b/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
index ca6a0d7516..1babbdc84e 100644
--- a/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
+++ b/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
@@ -101,7 +101,7 @@
#endif
#ifndef F_GETLK
-# ifndef __USE_FILE_OFFSET64
+# if !defined __USE_FILE_OFFSET64 && __TIMESIZE != 64
# define F_GETLK 5 /* Get record locking info. */
# define F_SETLK 6 /* Set record locking info (non-blocking). */
# define F_SETLKW 7 /* Set record locking info (blocking). */
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] io: Fix record locking contants on 32 bit arch with 64 bit default time_t (BZ#30477)
2023-05-25 13:51 [PATCH v2] io: Fix record locking contants on 32 bit arch with 64 bit default time_t (BZ#30477) Adhemerval Zanella
@ 2023-05-30 11:19 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2023-05-30 11:19 UTC (permalink / raw)
To: Adhemerval Zanella, libc-alpha, Bo YU
On 5/25/23 09:51, Adhemerval Zanella via Libc-alpha wrote:
> For architecture with default 64 bit time_t support, the kernel
> does not provide LFS and non-LFS values for F_GETLK, F_GETLK, and
> F_GETLK (the default value used for 64 bit architecture are used).
Right, and the mistake is that we need to use the 64-bit time_t-ness check to get
the right constants in userspace, which your patch fixes.
> This is might be considered an ABI break, but the currenct exported
> values is bogus anyway.
It *is* an ABI break, but if the previous values could never have worked then there
doesn't exist a program that can use the interface and this becomes a "bug fix"
that corrects an ABI mistake. This is OK with me.
> The POSIX lockf is not affected since it is aliased to lockf64,
> which already uses the LFS values.
>
> Checked on i686-linux-gnu and the new tests on a riscv32.
LGTM.
Passes all pre-commit CI.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> Changes from v1:
> * Remove parens on defined operator.
> * Make the test use tst-flock skeleton.
> ---
> io/Makefile | 1 +
> io/tst-fcntl-lock.c | 97 ++++++++++++++++++++++
> io/tst-lockf.c | 58 +++++++------
> sysdeps/unix/sysv/linux/bits/fcntl-linux.h | 2 +-
> 4 files changed, 133 insertions(+), 25 deletions(-)
> create mode 100644 io/tst-fcntl-lock.c
>
> diff --git a/io/Makefile b/io/Makefile
> index db886ca26f..d573064ecc 100644
> --- a/io/Makefile
> +++ b/io/Makefile
> @@ -175,6 +175,7 @@ tests := \
> tst-fchmodat \
> tst-fchownat \
> tst-fcntl \
> + tst-fcntl-lock \
OK. Add new test.
> tst-fstatat \
> tst-fts \
> tst-fts-lfs \
> diff --git a/io/tst-fcntl-lock.c b/io/tst-fcntl-lock.c
> new file mode 100644
> index 0000000000..357c4b7b56
> --- /dev/null
> +++ b/io/tst-fcntl-lock.c
> @@ -0,0 +1,97 @@
> +/* Test for advisory record locking.
OK.
> + Copyright (C) 2023 Free Software Foundation, Inc.
> +
> + This program is free software; you can redistribute it and/or
> + modify it under the terms of the GNU General Public License
> + as published by the Free Software Foundation; either version 2
> + of the License, or (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, see <https://www.gnu.org/licenses/>.
> +*/
> +
> +#include <fcntl.h>
> +#include <errno.h>
> +#include <unistd.h>
> +
> +/* This is essentially the POSIX lockf. */
OK. https://pubs.opengroup.org/onlinepubs/9699919799/functions/lockf.html
> +
> +static int
> +fcntl_lockf (int fd, int cmd, off_t len)
> +{
> + struct flock fl = {
> + .l_type = F_WRLCK,
> + .l_whence = SEEK_CUR,
> + .l_len = len
> + };
> +
> + switch (cmd)
> + {
> + case F_TEST:
> + fl.l_type = F_RDLCK;
> + if (fcntl (fd, F_GETLK, &fl) < 0)
> + return -1;
> + if (fl.l_type == F_UNLCK || fl.l_pid == getpid ())
> + return 0;
> + errno = EACCES;
> + return -1;
> +
> + case F_ULOCK:
> + fl.l_type = F_UNLCK;
> + return fcntl (fd, F_SETLK, &fl);
> +
> + case F_LOCK:
> + return fcntl (fd, F_SETLKW, &fl);
> +
> + case F_TLOCK:
> + return fcntl (fd, F_SETLK, &fl);
> + }
> +
> + errno = EINVAL;
> + return -1;
> +}
> +
> +static int
> +fcntl64_lockf (int fd, int cmd, off64_t len64)
> + {
> + struct flock64 fl64 = {
> + .l_type = F_WRLCK,
> + .l_whence = SEEK_CUR,
> + .l_len = len64
> + };
> +
> + switch (cmd)
> + {
> + case F_TEST:
> + fl64.l_type = F_RDLCK;
> + if (fcntl64 (fd, F_GETLK64, &fl64) < 0)
> + return -1;
> + if (fl64.l_type == F_UNLCK || fl64.l_pid == getpid ())
> + return 0;
> + errno = EACCES;
> + return -1;
> +
> + case F_ULOCK:
> + fl64.l_type = F_UNLCK;
> + return fcntl64 (fd, F_SETLK64, &fl64);
> +
> + case F_LOCK:
> + return fcntl64 (fd, F_SETLKW64, &fl64);
> +
> + case F_TLOCK:
> + return fcntl64 (fd, F_SETLK64, &fl64);
> + }
> +
> + errno = EINVAL;
> + return -1;
> +}
> +
> +#define TST_LOCKFD "tst-fcntl-lock."
> +#define LOCKF fcntl_lockf
> +#define LOCKF64 fcntl64_lockf
> +#include "tst-lockf.c"
OK. You build a lockf test and then implement lockf using fcntl to verify
the functionality works as expected.
> diff --git a/io/tst-lockf.c b/io/tst-lockf.c
> index eda04b5417..cf8d3001c3 100644
> --- a/io/tst-lockf.c
> +++ b/io/tst-lockf.c
> @@ -24,13 +24,23 @@
> #include <support/capture_subprocess.h>
> #include <support/check.h>
>
> +#ifndef TST_LOCKFD
> +# define TST_LOCKFD "tst-lockfd."
> +#endif
> +#ifndef LOCKF
> +# define LOCKF lockf
> +#endif
> +#ifndef LOCKF64
> +# define LOCKF64 lockf64
> +#endif
> +
> static char *temp_filename;
> static int temp_fd;
>
> static void
> do_prepare (int argc, char **argv)
> {
> - temp_fd = create_temp_file ("tst-lockfd.", &temp_filename);
> + temp_fd = create_temp_file (TST_LOCKFD, &temp_filename);
> TEST_VERIFY_EXIT (temp_fd != -1);
> }
> #define PREPARE do_prepare
> @@ -40,22 +50,22 @@ do_test_child_lockf (void *closure)
> {
> /* Check if parent has [0, 1024) locked. */
> TEST_COMPARE (lseek (temp_fd, 0, SEEK_SET), 0);
> - TEST_COMPARE (lockf (temp_fd, F_TLOCK, 1024), -1);
> + TEST_COMPARE (LOCKF (temp_fd, F_TLOCK, 1024), -1);
> TEST_COMPARE (errno, EAGAIN);
> - TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), -1);
> + TEST_COMPARE (LOCKF (temp_fd, F_TEST, 1024), -1);
> TEST_COMPARE (errno, EACCES);
> /* Also Check if parent has last 1024 bytes locked. */
> TEST_COMPARE (lseek (temp_fd, INT32_MAX-1024, SEEK_SET), INT32_MAX-1024);
> - TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), -1);
> + TEST_COMPARE (LOCKF (temp_fd, F_TEST, 1024), -1);
>
> /* And try to lock [1024, 2048). */
> TEST_COMPARE (lseek (temp_fd, 1024, SEEK_SET), 1024);
> - TEST_COMPARE (lockf (temp_fd, F_LOCK, 1024), 0);
> + TEST_COMPARE (LOCKF (temp_fd, F_LOCK, 1024), 0);
>
> /* Check if non-LFS interface cap access to 32-bif off_t. */
> TEST_COMPARE (lseek64 (temp_fd, (off64_t)INT32_MAX, SEEK_SET),
> (off64_t)INT32_MAX);
> - TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), 0);
> }
>
> static void
> @@ -63,32 +73,32 @@ do_test_child_lockf64 (void *closure)
> {
> /* Check if parent has [0, 1024) locked. */
> TEST_COMPARE (lseek64 (temp_fd, 0, SEEK_SET), 0);
> - TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), -1);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TLOCK, 1024), -1);
> TEST_COMPARE (errno, EAGAIN);
> - TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), -1);
> TEST_COMPARE (errno, EACCES);
> /* Also Check if parent has last 1024 bytes locked. */
> TEST_COMPARE (lseek64 (temp_fd, INT32_MAX-1024, SEEK_SET), INT32_MAX-1024);
> - TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), -1);
>
> /* And try to lock [1024, 2048). */
> TEST_COMPARE (lseek64 (temp_fd, 1024, SEEK_SET), 1024);
> - TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
>
> /* And also [INT32_MAX, INT32_MAX+1024). */
> {
> off64_t off = (off64_t)INT32_MAX;
> TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
> - TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
> }
>
> /* Check if [INT32_MAX+1024, INT64_MAX) is locked. */
> {
> off64_t off = (off64_t)INT32_MAX+1024;
> TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
> - TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), -1);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TLOCK, 1024), -1);
> TEST_COMPARE (errno, EAGAIN);
> - TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), -1);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), -1);
> TEST_COMPARE (errno, EACCES);
> }
> }
> @@ -97,38 +107,38 @@ static int
> do_test (void)
> {
> /* Basic tests to check if a lock can be obtained and checked. */
> - TEST_COMPARE (lockf (temp_fd, F_LOCK, 1024), 0);
> - TEST_COMPARE (lockf (temp_fd, F_LOCK, INT32_MAX), 0);
> - TEST_COMPARE (lockf (temp_fd, F_TLOCK, 1024), 0);
> - TEST_COMPARE (lockf (temp_fd, F_TEST, 1024), 0);
> + TEST_COMPARE (LOCKF (temp_fd, F_LOCK, 1024), 0);
> + TEST_COMPARE (LOCKF (temp_fd, F_LOCK, INT32_MAX), 0);
> + TEST_COMPARE (LOCKF (temp_fd, F_TLOCK, 1024), 0);
> + TEST_COMPARE (LOCKF (temp_fd, F_TEST, 1024), 0);
> TEST_COMPARE (lseek (temp_fd, 1024, SEEK_SET), 1024);
> - TEST_COMPARE (lockf (temp_fd, F_ULOCK, 1024), 0);
> + TEST_COMPARE (LOCKF (temp_fd, F_ULOCK, 1024), 0);
> /* Parent process should have ([0, 1024), [2048, INT32_MAX)) ranges locked. */
>
> {
> struct support_capture_subprocess result;
> result = support_capture_subprocess (do_test_child_lockf, NULL);
> - support_capture_subprocess_check (&result, "lockf", 0, sc_allow_none);
> + support_capture_subprocess_check (&result, "LOCKF", 0, sc_allow_none);
> }
>
> if (sizeof (off_t) != sizeof (off64_t))
> {
> /* Check if previously locked regions with LFS symbol. */
> TEST_COMPARE (lseek (temp_fd, 0, SEEK_SET), 0);
> - TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
> - TEST_COMPARE (lockf64 (temp_fd, F_TLOCK, 1024), 0);
> - TEST_COMPARE (lockf64 (temp_fd, F_TEST, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TLOCK, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_TEST, 1024), 0);
> /* Lock region [INT32_MAX+1024, INT64_MAX). */
> off64_t off = (off64_t)INT32_MAX + 1024;
> TEST_COMPARE (lseek64 (temp_fd, off, SEEK_SET), off);
> - TEST_COMPARE (lockf64 (temp_fd, F_LOCK, 1024), 0);
> + TEST_COMPARE (LOCKF64 (temp_fd, F_LOCK, 1024), 0);
> /* Parent process should have ([0, 1024), [2048, INT32_MAX),
> [INT32_MAX+1024, INT64_MAX)) ranges locked. */
>
> {
> struct support_capture_subprocess result;
> result = support_capture_subprocess (do_test_child_lockf64, NULL);
> - support_capture_subprocess_check (&result, "lockf", 0, sc_allow_none);
> + support_capture_subprocess_check (&result, "LOCKF", 0, sc_allow_none);
> }
> }
OK. Test fcntl-as-lockf using the lockf test.
>
> diff --git a/sysdeps/unix/sysv/linux/bits/fcntl-linux.h b/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
> index ca6a0d7516..1babbdc84e 100644
> --- a/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
> +++ b/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
> @@ -101,7 +101,7 @@
> #endif
>
> #ifndef F_GETLK
OK. And this is the fix. Resolves Andreas' comment about parentheses.
> -# ifndef __USE_FILE_OFFSET64
> +# if !defined __USE_FILE_OFFSET64 && __TIMESIZE != 64
Florian asked if there were any other cases of this, and you confirmed that there
were no other instances that you could find that would indicate the same logical
error elsewhere in the sources.
Notes here from you:
https://sourceware.org/pipermail/libc-alpha/2023-May/148502.html
> # define F_GETLK 5 /* Get record locking info. */
> # define F_SETLK 6 /* Set record locking info (non-blocking). */
> # define F_SETLKW 7 /* Set record locking info (blocking). */
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-30 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-25 13:51 [PATCH v2] io: Fix record locking contants on 32 bit arch with 64 bit default time_t (BZ#30477) Adhemerval Zanella
2023-05-30 11:19 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).