Re: [PATCH] posix: Deprecate group_member for Linux

[Joe Simmons-Talbott <josimmon@redhat.com>]

On Wed, Oct 04, 2023 at 09:06:03PM +0800, Xi Ruoyao wrote:
> On Thu, 2023-09-21 at 12:20 -0400, Joe Simmons-Talbott wrote:
> > diff --git a/sysdeps/unix/sysv/linux/group_member.h b/sysdeps/unix/sysv/linux/group_member.h
> > new file mode 100644
> > index 0000000000..9b24569d4e
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/group_member.h
> > @@ -0,0 +1,27 @@
> > +/* Copyright (C) 2023 Free Software Foundation, Inc.
> > +   This file is part of the GNU C Library.
> > +
> > +   The GNU C Library is free software; you can redistribute it and/or
> > +   modify it under the terms of the GNU Lesser General Public
> > +   License as published by the Free Software Foundation; either
> > +   version 2.1 of the License, or (at your option) any later version.
> > +
> > +   The GNU C Library is distributed in the hope that it will be useful,
> > +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > +   Lesser General Public License for more details.
> > +
> > +   You should have received a copy of the GNU Lesser General Public
> > +   License along with the GNU C Library; if not, see
> > +   <https://www.gnu.org/licenses/>.  */
> > +
> > +#ifndef _GROUP_MEMBER_H
> > +#define _GROUP_MEMBER_H 1
> > +
> > +#ifdef	__USE_GNU
> > +/* Return nonzero iff the calling process is in group GID.  Deprecated */
> > +extern int group_member (__gid_t __gid) __THROW
> > +	__attribute_deprecated__;
> 
> Maybe `__attribute_deprecated_msg__ ("may overflow the stack")` is
> better?  And should we have an alternate interface to replace it?

I'll add your suggestion in v2.  There is opposition to adding a
replacement group_member interface since it would require converting
from a boolean interface to a tri-state interface which are difficult
for programmers.

Thanks,
Joe