glibc test failures for x86_64-gnu since 25 Sep

glibc test failures for x86_64-gnu since 25 Sep

[Joseph Myers]

glibc tests have been failing for x86_64-gnu since around 25 September:

FAIL: hurd/check-installed-headers-cxx
FAIL: mach/check-installed-headers-cxx

The problem is mach/message.h containing a call to _Static_assert:

#ifdef __x86_64__
_Static_assert (sizeof (mach_msg_type_t) == sizeof (mach_msg_type_long_t),
                "mach_msg_type_t and mach_msg_type_long_t need to have the same size.");
#endif

GCC only accepts _Static_assert as a keyword in C; for C++ you have to use 
plain static_assert.  So this installed header isn't working for C++, 
since the gnumach commit:

commit 25ece371fb21dfd874187f623593064c476d9ca2
Author:     Flavio Cruz <flaviocruz@gmail.com>
AuthorDate: Tue Jun 13 00:01:25 2023 -0400
Commit:     Samuel Thibault <samuel.thibault@ens-lyon.org>
CommitDate: Mon Sep 25 10:58:14 2023 +0200

    Update the 64bit RPC ABI to be simpler

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: glibc test failures for x86_64-gnu since 25 Sep

[Samuel Thibault]

Joseph Myers, le jeu. 02 nov. 2023 21:44:04 +0000, a ecrit:
> GCC only accepts _Static_assert as a keyword in C; for C++ you have to use 
> plain static_assert.  So this installed header isn't working for C++, 
> since the gnumach commit:

Oh.

Thanks for the notice, now fixed!

Samuel

Re: glibc test failures for x86_64-gnu since 25 Sep

[Joseph Myers]

On Fri, 3 Nov 2023, Samuel Thibault wrote:

> Joseph Myers, le jeu. 02 nov. 2023 21:44:04 +0000, a ecrit:
> > GCC only accepts _Static_assert as a keyword in C; for C++ you have to use 
> > plain static_assert.  So this installed header isn't working for C++, 
> > since the gnumach commit:
> 
> Oh.
> 
> Thanks for the notice, now fixed!

The installed headers tests are still failing for C++98 mode, when the 
static_assert keyword doesn't exist either.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: glibc test failures for x86_64-gnu since 25 Sep

[Samuel Thibault]

Joseph Myers, le lun. 06 nov. 2023 20:46:41 +0000, a ecrit:
> On Fri, 3 Nov 2023, Samuel Thibault wrote:
> 
> > Joseph Myers, le jeu. 02 nov. 2023 21:44:04 +0000, a ecrit:
> > > GCC only accepts _Static_assert as a keyword in C; for C++ you have to use 
> > > plain static_assert.  So this installed header isn't working for C++, 
> > > since the gnumach commit:
> > 
> > Oh.
> > 
> > Thanks for the notice, now fixed!
> 
> The installed headers tests are still failing for C++98 mode, when the 
> static_assert keyword doesn't exist either.

Ah, right, fixed so.

Samuel