Re: [PATCH v5 1/1] memalign: Support scanning for aligned chunks.

[Stefan Liebler <stli@linux.ibm.com>]

On 29.03.23 22:36, DJ Delorie via Libc-alpha wrote:
> 
> Thanks!  Pushed.
> 
On s390 (31bit), I see the test fail:
FAIL: malloc/tst-memalign-2-mcheck

After adding those printfs ...:
diff --git a/malloc/tst-memalign-2.c b/malloc/tst-memalign-2.c
index 4996578e9f..adfebf8384 100644
--- a/malloc/tst-memalign-2.c
+++ b/malloc/tst-memalign-2.c
@@ -72,10 +72,12 @@ do_test (void)
     {
       tcache_allocs[i].ptr1 = memalign (tcache_allocs[i].alignment,
tcache_allocs[i].size);
       CHECK (tcache_allocs[i].ptr1, tcache_allocs[i].alignment);
+      printf ("%d# ptr1=%p\n", i, tcache_allocs[i].ptr1);
       free (tcache_allocs[i].ptr1);
       /* This should return the same chunk as was just free'd.  */
       tcache_allocs[i].ptr2 = memalign (tcache_allocs[i].alignment,
tcache_allocs[i].size);
       CHECK (tcache_allocs[i].ptr2, tcache_allocs[i].alignment);
+      printf ("%d# ptr2=%p\n", i, tcache_allocs[i].ptr2);
       free (tcache_allocs[i].ptr2);

       TEST_VERIFY (tcache_allocs[i].ptr1 == tcache_allocs[i].ptr2);


... I've got this output:
0# ptr1=0x55bc71b8
0# ptr2=0x55bc71b8
1# ptr1=0x55bc7210
1# ptr2=0x55bc7260
error: tst-memalign-2.c:83: not true: tcache_allocs[i].ptr1 ==
tcache_allocs[i].ptr2
2# ptr1=0x55bc72e0
2# ptr2=0x55bc72e0
error: 1 test failures


malloc/tst-memalign-2 (without mcheck) is passing.
PASS: malloc/tst-memalign-2
original exit status 0
0# ptr1=0x55c0e190
0# ptr2=0x55c0e190
1# ptr1=0x55c0e190
1# ptr2=0x55c0e190
2# ptr1=0x55c0e1c0
2# ptr2=0x55c0e1c0

Can you please help.

Thanks,
Stefan