From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: <libc-alpha@sourceware.org>,
Noah Goldstein <goldstein.w.n@gmail.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH 0/1] Add linting checks to 'make check'
Date: Fri, 19 May 2023 16:55:51 +0000 [thread overview]
Message-ID: <20c53d6b-b567-346b-4b3f-26c250a91e4@codesourcery.com> (raw)
In-Reply-To: <20230519121354.704395-1-carlos@redhat.com>
On Fri, 19 May 2023, Carlos O'Donell via Libc-alpha wrote:
> acceptable to lint the Makefile format in 'make check' itself. The check
> needs to run the python interpreter about 200 times, but it's fairly
> fast and on a slow system takes ~3s. My gut feeling is that basic
If something is significantly slower, I'd suggest parallelizing at the
makefile level (not relevant for a 3s test, but certainly helps for e.g.
the conform/ tests which take quite a lot of time if run in serial but are
extremely parallel).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-05-19 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 12:13 Carlos O'Donell
2023-05-19 12:13 ` [PATCH 1/1] Add lint-makefiles Makefile linting test Carlos O'Donell
2023-05-19 12:35 ` Alejandro Colomar
2023-05-19 12:45 ` Florian Weimer
2023-05-23 14:05 ` Carlos O'Donell
2023-05-30 12:10 ` Carlos O'Donell
2023-05-19 16:55 ` Joseph Myers [this message]
2023-05-23 12:54 ` [PATCH 0/1] Add linting checks to 'make check' Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20c53d6b-b567-346b-4b3f-26c250a91e4@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).